git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git log [diff-tree options]...

From
Linus Torvalds <torvalds@osdl.org>
Date
Apr 10, 2006, 23:54 UTC
Message-ID
<Pine.LNX.4.64.0604101652220.2998@g5.osdl.org>
In-Reply-To
<7vodz980az.fsf@assigned-by-dhcp.cox.net>
On Mon, 10 Apr 2006, Junio C Hamano wrote:
Show 9 quoted lines
> >
> > and I think we'd likely want to have some way to select the output. 
> > Probably with the path-limited diff being the default (that's what 
> > "git-whatchanged" does), but perhaps with "--full-diff" showing the whole 
> > commit diff (which is what "gitk" does).
> 
> Yes, but it turns out it is a bit tricky, given that the way
> tree-diff.c is written it pretty much assumes the same pathspec
> is used for diff operation during the lifetime of the process.

Hmm.. The hacky approach would seem to be to just call "diff_tree_setup_paths()" just before doing the diff (and re-set it afterwards). That should work, I don't think we keep any real state around.

> I think we should move (nr_paths, pathlens and paths) to struct
> diff_options.  Two patches to follow shortly.

That certainly seems to be the cleanest option. Not just because it should solve this problem, but because it's also what looks most natural anyway (and matches the "struct revs" approach).

		Linus
Previous: Junio C Hamano
Message 22 of 22 in “git log [diff-tree options]...”
  1. git log [diff-tree options]...Junio C Hamano, Apr 9, 2006
  2. Junio C HamanoApr 9, 2006
  3. Linus TorvaldsApr 9, 2006
  4. Junio C HamanoApr 9, 2006
  5. Linus TorvaldsApr 9, 2006
  6. Junio C HamanoApr 9, 2006
  7. Linus TorvaldsApr 9, 2006
  8. Johannes SchindelinApr 9, 2006
  9. Johannes SchindelinApr 9, 2006
  10. Timo HirvonenApr 9, 2006
  11. Johannes SchindelinApr 10, 2006
  12. Junio C HamanoApr 9, 2006
  13. Linus TorvaldsApr 10, 2006
  14. Johannes SchindelinApr 10, 2006
  15. Randal L. SchwartzApr 11, 2006
  16. Junio C HamanoApr 11, 2006
  17. Petr BaudisApr 11, 2006
  18. Randal L. SchwartzApr 11, 2006
  19. Junio C HamanoApr 10, 2006
  20. tree-diff: do not assume we use only one pathspecJunio C Hamano, Apr 10, 2006
  21. git log --full-diffJunio C Hamano, Apr 10, 2006
  22. Linus TorvaldsApr 10, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.