Re: [PATCH] git log [diff-tree options]...

From: Linus Torvalds <torvalds@osdl.org>
Date: Apr 10, 2006, 00:06 UTC
Message-ID: <Pine.LNX.4.64.0604091702190.9504@g5.osdl.org>
In-Reply-To: <7vy7ye9uk8.fsf@assigned-by-dhcp.cox.net>

On Sun, 9 Apr 2006, Junio C Hamano wrote:

> 
> I do not think so.  You should default to --cc only there is no
> explicit command line stuff from the user.

Actually, even that would be wrong, when I think more about it. The default for "git-whatchanged" is to do diffing, but default to the "raw" diff (just "-r" for recursive).

So the most appropriate default set of flags is likely "-r -c", which also means that any subsequent explicit command line stuff will override it (ie adding a "-p" should automatically do the right thing).

But the "memmove()" to move the arguments around was definitely broken. Much better to just initialize the diff flags manually, I think.

		Linus