Re: [PATCH] git log [diff-tree options]...

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 10, 2006, 08:10 UTC
Message-ID: <Pine.LNX.4.63.0604101010001.31612@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20060410012258.589f1581.tihirvon@gmail.com>

Hi,

On Mon, 10 Apr 2006, Timo Hirvonen wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> 
> > +static int cmd_whatchanged(int argc, const char **argv, char **envp)
> > +{
> > +	memmove(argv + 2, argv + 1, argc - 1);
> 
> Shouldn't the size be sizeof(char *) * argc (NULL terminated array)?
> There's also overflow...

Yeah, this was some useless late-night coding. But you get the idea.

Ciao, Dscho