git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: StGIT: "stg new" vs "stg new --force"

From
Yann Dirson <ydirson@altern.org>
Date
Jan 19, 2006, 21:38 UTC
Message-ID
<20060119213838.GA27397@nowhere.earth>
In-Reply-To
<1137631749.13853.22.camel@dv>
On Wed, Jan 18, 2006 at 07:49:09PM -0500, Pavel Roskin wrote:
Show 9 quoted lines
> > But it would not be a replacement to selecting changes with a
> > granularity finer than file-level, which is what I wanted to suggest.
> 
> Why?  Maybe you got confused by two meanings of the word "patch"?  I
> think StGIT should use some other term, e.g. changeset.  I meant that
> the diff file (e.g. made by "stg diff") could be edited and folded into
> one of the StGIT patches (changesets).  Unless you want non-interactive
> separation of the hunks, using an editor should be a reasonable
> approach.
> My approach suggests that the user work with the diff from the
> beginning, and separates the changes by looking at them.

Oh, I think I now see what you meant. I'm not sure it would be a good idea to let the user edit the diff, although running an editor on it is not much different from feeding it through filterdiff, or a even through a graphical equivalent allowing to point at the hunks.

> I believe StGIT should be primarily designed to be used interactively.

I tend to disagree. 3rd-party apps like qgit should be able to let the user do the selection, and tell the command-line tool what they want to act upon. It may be useful as well if stg gains interactivity, but should not become the only way to work with it (unix way of life).

> Your approach looks like a usability disaster to me.  The user is
> supposed to find numbers of the hunks, although s/he is working on the
> whole file (since it's "stg refresh").

That's what I'm currently doing to feed the hunk numbers to filterdiff. Any improvement in the process would be welcomed :)

Maybe we could have a "fold" or "refresh" variant that takes its output from the output of "stg diff" (or any arbitrary diff on stdin, to be friendly with GUI wrappers) filtered by an arbitrary command. That command could be "cat" to get the current "refresh" behaviour, or an editor wrapper acting on stdin/out, or a wrapper to filterdiff, or whatever clever filter one would want to use.

Does it sound better ?
-- 
Yann Dirson    <ydirson@altern.org> |
Debian-related: <dirson@debian.org> |   Support Debian GNU/Linux:
                                    |  Freedom, Power, Stability, Gratis
     http://ydirson.free.fr/        | Check <http://www.debian.org/>
Previous: Pavel RoskinNext: Pavel Roskin
Message 9 of 19 in “StGIT: "stg new" vs "stg new --force"”
  1. Pavel RoskinJan 13, 2006
  2. Karl HasselströmJan 13, 2006
  3. Catalin MarinasJan 16, 2006
  4. Pavel RoskinJan 17, 2006
  5. Yann DirsonJan 17, 2006
  6. Pavel RoskinJan 17, 2006
  7. Yann DirsonJan 18, 2006
  8. Pavel RoskinJan 19, 2006
  9. Yann DirsonJan 19, 2006
  10. Pavel RoskinJan 20, 2006
  11. J. Bruce FieldsJan 20, 2006
  12. Pavel RoskinJan 24, 2006
  13. J. Bruce FieldsJan 24, 2006
  14. Pavel RoskinJan 24, 2006
  15. Catalin MarinasJan 24, 2006
  16. Catalin MarinasJan 21, 2006
  17. Pavel RoskinJan 22, 2006
  18. Catalin MarinasJan 21, 2006
  19. Catalin MarinasJan 21, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.