git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] mailsplit.c: remove dead code

From
Stefan Beller <stefanbeller@gmail.com>
Date
Aug 11, 2014, 21:11 UTC
Message-ID
<1407791481-17410-1-git-send-email-stefanbeller@gmail.com>
This was found by coverity. (Id: 290001)

the variable 'output' is only assigned to a value inequal to NUL, after all gotos to the corrupt label. Therefore we can conclude the two removed lines are actually dead code.

Signed-off-by: Stefan Beller <stefanbeller@gmail.com>
---
 builtin/mailsplit.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/builtin/mailsplit.c b/builtin/mailsplit.c
index 06296d4..b499014 100644
--- a/builtin/mailsplit.c
+++ b/builtin/mailsplit.c
@@ -93,8 +93,6 @@ static int split_one(FILE *mbox, const char *name, int allow_bare)
 	return status;
 
  corrupt:
-	if (output)
-		fclose(output);
 	unlink(name);
 	fprintf(stderr, "corrupt mailbox\n");
 	exit(1);
-- 
2.1.0.rc2
Next: René Scharfe
Message 1 of 9 in “mailsplit.c: remove dead code”
  1. mailsplit.c: remove dead codeStefan Beller, Aug 11, 2014
  2. René ScharfeAug 12, 2014
  3. mailsplit.c: remove dead codeStefan Beller, Aug 12, 2014
  4. Matthieu MoyAug 12, 2014
  5. Junio C HamanoAug 12, 2014
  6. Junio C HamanoAug 12, 2014
  7. Matthieu MoyAug 12, 2014
  8. Jonathan NiederAug 12, 2014
  9. Jeff KingAug 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.