Re: [PATCH] mailsplit.c: remove dead code

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 12, 2014, 21:50 UTC
Message-ID: <CAPc5daVuO9_wNCSzTi2PFb5JGKSw_awdsUaFNZS_S7v89fAZHg@mail.gmail.com>
In-Reply-To: <xmqqvbpx4cd6.fsf@gitster.dls.corp.google.com>

... answering to myself, the only invoker does not seem to care, so I do not mind if the fprintf/exit gets turned into die() in a follow-up patch.

Thanks.

On Tue, Aug 12, 2014 at 2:38 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Stefan Beller <stefanbeller@gmail.com> writes:
>>
>>> +    if (is_bare && !allow_bare) {
>>> +            unlink(name);
>>> +            fprintf(stderr, "corrupt mailbox\n");
>>> +            exit(1);
>>> +    }
>>
>> Not directly related to your patch, but shouldn't this be using
>>
>> die(_("corrupt mailbox"));
>>
>> instead?
>
> Doesn't the exit status of mailsplit matter to its existing
> invokers?