From: Stefan Beller Date: Mon, 11 Aug 2014 21:11:21 GMT Subject: [PATCH] mailsplit.c: remove dead code Message-ID: <1407791481-17410-1-git-send-email-stefanbeller@gmail.com> This was found by coverity. (Id: 290001) the variable 'output' is only assigned to a value inequal to NUL, after all gotos to the corrupt label. Therefore we can conclude the two removed lines are actually dead code. Signed-off-by: Stefan Beller --- builtin/mailsplit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/builtin/mailsplit.c b/builtin/mailsplit.c index 06296d4..b499014 100644 --- a/builtin/mailsplit.c +++ b/builtin/mailsplit.c @@ -93,8 +93,6 @@ static int split_one(FILE *mbox, const char *name, int allow_bare) return status; corrupt: - if (output) - fclose(output); unlink(name); fprintf(stderr, "corrupt mailbox\n"); exit(1); -- 2.1.0.rc2