Re: [PATCH] mailsplit.c: remove dead code

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Aug 12, 2014, 21:56 UTC
Message-ID: <vpqd2c5z81w.fsf@anie.imag.fr>
In-Reply-To: <xmqqvbpx4cd6.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 18 quoted lines

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Stefan Beller <stefanbeller@gmail.com> writes:
>>
>>> +	if (is_bare && !allow_bare) {
>>> +		unlink(name);
>>> +		fprintf(stderr, "corrupt mailbox\n");
>>> +		exit(1);
>>> +	}
>>
>> Not directly related to your patch, but shouldn't this be using
>>
>> die(_("corrupt mailbox"));
>>
>> instead?
>
> Doesn't the exit status of mailsplit matter to its existing
> invokers?

Not within Git. I doubt anybody checks if the exit status is 1 and relies on that for corrupt mailboxes, but OTOH, changing the code may not be worth the trouble.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/