Re: [PATCH] mailsplit.c: remove dead code

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 12, 2014, 22:58 UTC
Message-ID: <20140812225826.GC24621@google.com>
In-Reply-To: <1407878487-23530-1-git-send-email-stefanbeller@gmail.com>

Stefan Beller wrote:

> This was found by coverity. (Id: 290001)

[...]

Show 5 quoted lines

> Signed-off-by: Stefan Beller <stefanbeller@gmail.com>
> Helped-by: René Scharfe <l.s.r@web.de>
> ---
>  builtin/mailsplit.c | 17 ++++++-----------
>  1 file changed, 6 insertions(+), 11 deletions(-)

The idea is to simplify error handling (removing cleanup of the 'output' var) by making it more obvious that there is only one kind of error, right?

For what it's worth, it looks good to me (and much clearer than the last version). It's always possible to reintroduce goto-based error handling later if another kind of error is introduced, and in the meantime this is simpler and does not change behavior.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.