git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC 05/12] gettextize: git-submodule $update_module say + die messages

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 13, 2010, 22:09 UTC
Message-ID
<1284415758-20931-6-git-send-email-avarab@gmail.com>
In-Reply-To
<1284415758-20931-1-git-send-email-avarab@gmail.com>

Gettextize $update_module say and die messages. These messages needed to be split up to make them translatable.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 git-submodule.sh |   17 ++++++++---------
 1 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 1b3132f..2b33c5f 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -479,24 +479,23 @@ cmd_update()
 			case "$update_module" in
 			rebase)
 				command="git rebase"
-				action="rebase"
-				msg="rebased onto"
+				die_msg="$(eval_gettext "Unable to rebase '\$sha1' in submodule path '\$path'")"
+				say_msg="$(eval_gettext "Submodule path '\$path': rebased into '\$sha1'")"
 				;;
 			merge)
 				command="git merge"
-				action="merge"
-				msg="merged in"
+				die_msg="$(eval_gettext "Unable to rebase '\$sha1' in submodule path '\$path'")"
+				say_msg="$(eval_gettext "Submodule path '\$path': merged in '\$sha1'")"
 				;;
 			*)
 				command="git checkout $force -q"
-				action="checkout"
-				msg="checked out"
+				die_msg="$(eval_gettext "Unable to rebase '\$sha1' in submodule path '\$path'")"
+				say_msg="$(eval_gettext "Submodule path '\$path': checked out '\$sha1'")"
 				;;
 			esac
 
-			(clear_local_git_env; cd "$path" && $command "$sha1") ||
-			die "Unable to $action '$sha1' in submodule path '$path'"
-			say "Submodule path '$path': $msg '$sha1'"
+			(clear_local_git_env; cd "$path" && $command "$sha1") || die $die_msg
+			say $say_msg
 		fi
 
 		if test -n "$recursive"
-- 
1.7.3.rc1.220.gb4d42
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 6 of 13 in “gettextize: git-submodule”
  1. 00/12 gettextize: git-submoduleÆvar Arnfjörð Bjarmason, Sep 13, 2010
  2. 01/12 gettextize: git-submodule add git-sh-i18nÆvar Arnfjörð Bjarmason, Sep 13, 2010
  3. 02/12 gettextize: git-submodule echo + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  4. 03/12 gettextize: git-submodule say + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  5. 04/12 gettextize: git-submodule die + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  6. 05/12 gettextize: git-submodule $update_module say + die messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  7. 06/12 gettextize: git-submodule "cached cannot be used" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  8. 07/12 gettextize: git-submodule "Submodule change[...]" messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  9. 08/12 gettextize: git-submodule $errmsg messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  10. 09/12 gettextize: git-submodule "Entering [...]" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  11. 10/12 gettextize: git-submodule "[...] path is ignored" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  12. 11/12 gettextize: git-submodule "path not initialized" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  13. 12/12 gettextize: git-submodule "blob" and "submodule" messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.