git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC 08/12] gettextize: git-submodule $errmsg messages

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 13, 2010, 22:09 UTC
Message-ID
<1284415758-20931-9-git-send-email-avarab@gmail.com>
In-Reply-To
<1284415758-20931-1-git-send-email-avarab@gmail.com>

Gettextize warning messages stored in the $errmsg variable using eval_gettext interpolation. This is explicitly tested for so we need to skip some tests with NO_GETTEXT_POISON.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 git-submodule.sh             |    6 +++---
 t/t7401-submodule-summary.sh |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 065b343..d453fe9 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -643,13 +643,13 @@ cmd_summary() {
 		total_commits=
 		case "$missing_src,$missing_dst" in
 		t,)
-			errmsg="  Warn: $name doesn't contain commit $sha1_src"
+			errmsg="$(eval_gettext "  Warn: \$name doesn't contain commit \$sha1_src")"
 			;;
 		,t)
-			errmsg="  Warn: $name doesn't contain commit $sha1_dst"
+			errmsg="$(eval_gettext "  Warn: \$name doesn't contain commit \$sha1_dst")"
 			;;
 		t,t)
-			errmsg="  Warn: $name doesn't contain commits $sha1_src and $sha1_dst"
+			errmsg="$(eval_gettext "  Warn: \$name doesn't contain commits \$sha1_src and \$sha1_dst")"
 			;;
 		*)
 			errmsg=
diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh
index 70b2fb1..09ef760 100755
--- a/t/t7401-submodule-summary.sh
+++ b/t/t7401-submodule-summary.sh
@@ -154,7 +154,7 @@ EOF
 rm -f sm1 &&
 test_create_repo sm1 &&
 head6=$(add_file sm1 foo6 foo7)
-test_expect_success 'nonexistent commit' "
+test_expect_success NO_GETTEXT_POISON 'nonexistent commit' "
     git submodule summary >actual &&
     cat >expected <<-EOF &&
 * sm1 $head4...$head6:
-- 
1.7.3.rc1.220.gb4d42
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 9 of 13 in “gettextize: git-submodule”
  1. 00/12 gettextize: git-submoduleÆvar Arnfjörð Bjarmason, Sep 13, 2010
  2. 01/12 gettextize: git-submodule add git-sh-i18nÆvar Arnfjörð Bjarmason, Sep 13, 2010
  3. 02/12 gettextize: git-submodule echo + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  4. 03/12 gettextize: git-submodule say + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  5. 04/12 gettextize: git-submodule die + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  6. 05/12 gettextize: git-submodule $update_module say + die messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  7. 06/12 gettextize: git-submodule "cached cannot be used" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  8. 07/12 gettextize: git-submodule "Submodule change[...]" messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  9. 08/12 gettextize: git-submodule $errmsg messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  10. 09/12 gettextize: git-submodule "Entering [...]" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  11. 10/12 gettextize: git-submodule "[...] path is ignored" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  12. 11/12 gettextize: git-submodule "path not initialized" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  13. 12/12 gettextize: git-submodule "blob" and "submodule" messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.