git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC 09/12] gettextize: git-submodule "Entering [...]" message

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 13, 2010, 22:09 UTC
Message-ID
<1284415758-20931-10-git-send-email-avarab@gmail.com>
In-Reply-To
<1284415758-20931-1-git-send-email-avarab@gmail.com>

Gettextize the "Entering [...]" message. This is explicitly tested for so we need to skip some tests with NO_GETTEXT_POISON.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 git-submodule.sh             |    2 +-
 t/t7407-submodule-foreach.sh |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index d453fe9..6ec6aa5 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -291,7 +291,7 @@ cmd_foreach()
 	do
 		if test -e "$path"/.git
 		then
-			say "Entering '$prefix$path'"
+			say "$(eval_gettext "Entering '\$prefix\$path'")"
 			name=$(module_name "$path")
 			(
 				prefix="$prefix$path/"
diff --git a/t/t7407-submodule-foreach.sh b/t/t7407-submodule-foreach.sh
index 905a8ba..217fe55 100755
--- a/t/t7407-submodule-foreach.sh
+++ b/t/t7407-submodule-foreach.sh
@@ -68,7 +68,7 @@ Entering 'sub3'
 $pwd/clone-foo3-sub3-$sub3sha1
 EOF
 
-test_expect_success 'test basic "submodule foreach" usage' '
+test_expect_success NO_GETTEXT_POISON 'test basic "submodule foreach" usage' '
 	git clone super clone &&
 	(
 		cd clone &&
@@ -153,7 +153,7 @@ Entering 'sub2'
 Entering 'sub3'
 EOF
 
-test_expect_success 'test messages from "foreach --recursive"' '
+test_expect_success NO_GETTEXT_POISON 'test messages from "foreach --recursive"' '
 	(
 		cd clone2 &&
 		git submodule foreach --recursive "true" > ../actual
-- 
1.7.3.rc1.220.gb4d42
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 10 of 13 in “gettextize: git-submodule”
  1. 00/12 gettextize: git-submoduleÆvar Arnfjörð Bjarmason, Sep 13, 2010
  2. 01/12 gettextize: git-submodule add git-sh-i18nÆvar Arnfjörð Bjarmason, Sep 13, 2010
  3. 02/12 gettextize: git-submodule echo + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  4. 03/12 gettextize: git-submodule say + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  5. 04/12 gettextize: git-submodule die + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  6. 05/12 gettextize: git-submodule $update_module say + die messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  7. 06/12 gettextize: git-submodule "cached cannot be used" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  8. 07/12 gettextize: git-submodule "Submodule change[...]" messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  9. 08/12 gettextize: git-submodule $errmsg messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010
  10. 09/12 gettextize: git-submodule "Entering [...]" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  11. 10/12 gettextize: git-submodule "[...] path is ignored" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  12. 11/12 gettextize: git-submodule "path not initialized" messageÆvar Arnfjörð Bjarmason, Sep 13, 2010
  13. 12/12 gettextize: git-submodule "blob" and "submodule" messagesÆvar Arnfjörð Bjarmason, Sep 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.