threads / patch / 63291

patchrevision: remove log_reencode field from rev_info

Subject: [GSoC PATCH] revision: remove log_reencode field from rev_info

## tl;dr

3 messages between Apr 14, 2025 and Apr 16, 2025. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Lucas Seiki Oshiro· Apr 14, 2025, 15:14 UTC · lore
Remove the log_reencode field from struct rev-info, as it is not used.
Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---
Just a simple cleanup patch removing this unused field.

When I was working in a previous patchset (this: https://lore.kernel.org/git/20250303220029.10716-1-lucasseikioshiro@gmail.com/) I noticed that this field wasn't used anywhere in the code.

I also saw that it hasn't been used since it's introduction in 2006, in commit 52883fb.

 revision.h | 1 -
 1 file changed, 1 deletion(-)
Show changes to revision.h +0 −1
diff --git a/revision.h b/revision.h
index 71e984c452..87f8d798c2 100644
--- a/revision.h
+++ b/revision.h
@@ -292,7 +292,6 @@ struct rev_info {
 	struct string_list *ref_message_ids;
 	int		add_signoff;
 	const char	*extra_headers;
-	const char	*log_reencode;
 	const char	*subject_prefix;
 	int		patch_name_max;
 	int		no_inline;

-- 
2.39.5 (Apple Git-154)
Patrick Steinhardt· Apr 16, 2025, 08:54 UTC · re: Lucas Seiki Oshiro · lore

Re: [GSoC PATCH] revision: remove log_reencode field from rev_info

On Mon, Apr 14, 2025 at 12:14:38PM -0300, Lucas Seiki Oshiro wrote:
Show 13 quoted lines
> Remove the log_reencode field from struct rev-info, as it is not used.
> 
> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
> ---
> 
> Just a simple cleanup patch removing this unused field.
> 
> When I was working in a previous patchset (this:
> https://lore.kernel.org/git/20250303220029.10716-1-lucasseikioshiro@gmail.com/)
> I noticed that this field wasn't used anywhere in the code.
> 
> I also saw that it hasn't been used since it's introduction in 2006, in
> commit 52883fb.

Nit, not worth a reroll: historic information like this is always a nice addition to the commit message so that other people don't have to dig into history themselves to figure out why the field isn't used anymore.

Show 15 quoted lines
>  revision.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/revision.h b/revision.h
> index 71e984c452..87f8d798c2 100644
> --- a/revision.h
> +++ b/revision.h
> @@ -292,7 +292,6 @@ struct rev_info {
>  	struct string_list *ref_message_ids;
>  	int		add_signoff;
>  	const char	*extra_headers;
> -	const char	*log_reencode;
>  	const char	*subject_prefix;
>  	int		patch_name_max;
>  	int		no_inline;
The patch looks obviously good to me, thanks!
Patrick
Lucas Seiki Oshiro· Apr 16, 2025, 16:02 UTC · re: Patrick Steinhardt · lore

Re: [GSoC PATCH] revision: remove log_reencode field from rev_info

> Nit, not worth a reroll: historic information like this is always a nice
> addition to the commit message so that other people don't have to dig
> into history themselves to figure out why the field isn't used anymore.
Ooops, sorry
> The patch looks obviously good to me, thanks!
Thank you for reviewing another patch of mine!

← back to recent threads