# [GSoC PATCH] revision: remove log_reencode field from rev_info 3 messages from 2025-04-14 to 2025-04-16. Participants: Lucas Seiki Oshiro, Patrick Steinhardt. Thread: https://gitlist.dev/t/63291 ## Lucas Seiki Oshiro, 2025-04-14 15:14 Subject: [GSoC PATCH] revision: remove log_reencode field from rev_info Message-ID: <20250414151438.22232-1-lucasseikioshiro@gmail.com> URL: https://gitlist.dev/e/20250414151438.22232-1-lucasseikioshiro%40gmail.com ``` Remove the log_reencode field from struct rev-info, as it is not used. Signed-off-by: Lucas Seiki Oshiro --- Just a simple cleanup patch removing this unused field. When I was working in a previous patchset (this: https://lore.kernel.org/git/20250303220029.10716-1-lucasseikioshiro@gmail.com/) I noticed that this field wasn't used anywhere in the code. I also saw that it hasn't been used since it's introduction in 2006, in commit 52883fb. revision.h | 1 - 1 file changed, 1 deletion(-) diff --git a/revision.h b/revision.h index 71e984c452..87f8d798c2 100644 --- a/revision.h +++ b/revision.h @@ -292,7 +292,6 @@ struct rev_info { struct string_list *ref_message_ids; int add_signoff; const char *extra_headers; - const char *log_reencode; const char *subject_prefix; int patch_name_max; int no_inline; -- 2.39.5 (Apple Git-154) ``` ## Patrick Steinhardt, 2025-04-16 08:54 Subject: Re: [GSoC PATCH] revision: remove log_reencode field from rev_info Message-ID: URL: https://gitlist.dev/e/Z_9wQLTtj9t45Wjj%40pks.im In-Reply-To: <20250414151438.22232-1-lucasseikioshiro@gmail.com> ``` On Mon, Apr 14, 2025 at 12:14:38PM -0300, Lucas Seiki Oshiro wrote: > Remove the log_reencode field from struct rev-info, as it is not used. > > Signed-off-by: Lucas Seiki Oshiro > --- > > Just a simple cleanup patch removing this unused field. > > When I was working in a previous patchset (this: > https://lore.kernel.org/git/20250303220029.10716-1-lucasseikioshiro@gmail.com/) > I noticed that this field wasn't used anywhere in the code. > > I also saw that it hasn't been used since it's introduction in 2006, in > commit 52883fb. Nit, not worth a reroll: historic information like this is always a nice addition to the commit message so that other people don't have to dig into history themselves to figure out why the field isn't used anymore. > revision.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/revision.h b/revision.h > index 71e984c452..87f8d798c2 100644 > --- a/revision.h > +++ b/revision.h > @@ -292,7 +292,6 @@ struct rev_info { > struct string_list *ref_message_ids; > int add_signoff; > const char *extra_headers; > - const char *log_reencode; > const char *subject_prefix; > int patch_name_max; > int no_inline; The patch looks obviously good to me, thanks! Patrick ``` ## Lucas Seiki Oshiro, 2025-04-16 16:02 Subject: Re: [GSoC PATCH] revision: remove log_reencode field from rev_info Message-ID: URL: https://gitlist.dev/e/C8DDA8D1-A241-4DD0-876B-F2F859FD6073%40gmail.com In-Reply-To: ``` > Nit, not worth a reroll: historic information like this is always a nice > addition to the commit message so that other people don't have to dig > into history themselves to figure out why the field isn't used anymore. Ooops, sorry > The patch looks obviously good to me, thanks! Thank you for reviewing another patch of mine! ```