{"thread":{"id":"63291","subject":"[GSoC PATCH] revision: remove log_reencode field from rev_info","startedAt":"2025-04-14T15:15:07Z","lastAt":"2025-04-16T16:02:34Z","messageCount":3,"participants":["Lucas Seiki Oshiro","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"516106","messageId":"20250414151438.22232-1-lucasseikioshiro@gmail.com","threadId":"63291","inReplyTo":null,"subject":"[GSoC PATCH] revision: remove log_reencode field from rev_info","fromName":"Lucas Seiki Oshiro","fromEmail":"lucasseikioshiro@gmail.com","sentAt":"2025-04-14T15:14:38Z","receivedAt":"2025-04-14T15:15:07Z","isPatch":true,"sender":{"key":"lucasseikioshiro@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12701580?v=4"},"body":"Remove the log_reencode field from struct rev-info, as it is not used.\n\nSigned-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>\n---\n\nJust a simple cleanup patch removing this unused field.\n\nWhen I was working in a previous patchset (this:\nhttps://lore.kernel.org/git/20250303220029.10716-1-lucasseikioshiro@gmail.com/)\nI noticed that this field wasn't used anywhere in the code.\n\nI also saw that it hasn't been used since it's introduction in 2006, in\ncommit 52883fb.\n\n revision.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/revision.h b/revision.h\nindex 71e984c452..87f8d798c2 100644\n--- a/revision.h\n+++ b/revision.h\n@@ -292,7 +292,6 @@ struct rev_info {\n \tstruct string_list *ref_message_ids;\n \tint\t\tadd_signoff;\n \tconst char\t*extra_headers;\n-\tconst char\t*log_reencode;\n \tconst char\t*subject_prefix;\n \tint\t\tpatch_name_max;\n \tint\t\tno_inline;\n-- \n2.39.5 (Apple Git-154)\n\n"},{"id":"516261","messageId":"Z_9wQLTtj9t45Wjj@pks.im","threadId":"63291","inReplyTo":"20250414151438.22232-1-lucasseikioshiro@gmail.com","subject":"Re: [GSoC PATCH] revision: remove log_reencode field from rev_info","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-04-16T08:54:24Z","receivedAt":"2025-04-16T09:06:09Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Apr 14, 2025 at 12:14:38PM -0300, Lucas Seiki Oshiro wrote:\n> Remove the log_reencode field from struct rev-info, as it is not used.\n> \n> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>\n> ---\n> \n> Just a simple cleanup patch removing this unused field.\n> \n> When I was working in a previous patchset (this:\n> https://lore.kernel.org/git/20250303220029.10716-1-lucasseikioshiro@gmail.com/)\n> I noticed that this field wasn't used anywhere in the code.\n> \n> I also saw that it hasn't been used since it's introduction in 2006, in\n> commit 52883fb.\n\nNit, not worth a reroll: historic information like this is always a nice\naddition to the commit message so that other people don't have to dig\ninto history themselves to figure out why the field isn't used anymore.\n\n>  revision.h | 1 -\n>  1 file changed, 1 deletion(-)\n> \n> diff --git a/revision.h b/revision.h\n> index 71e984c452..87f8d798c2 100644\n> --- a/revision.h\n> +++ b/revision.h\n> @@ -292,7 +292,6 @@ struct rev_info {\n>  \tstruct string_list *ref_message_ids;\n>  \tint\t\tadd_signoff;\n>  \tconst char\t*extra_headers;\n> -\tconst char\t*log_reencode;\n>  \tconst char\t*subject_prefix;\n>  \tint\t\tpatch_name_max;\n>  \tint\t\tno_inline;\n\nThe patch looks obviously good to me, thanks!\n\nPatrick\n"},{"id":"516300","messageId":"C8DDA8D1-A241-4DD0-876B-F2F859FD6073@gmail.com","threadId":"63291","inReplyTo":"Z_9wQLTtj9t45Wjj@pks.im","subject":"Re: [GSoC PATCH] revision: remove log_reencode field from rev_info","fromName":"Lucas Seiki Oshiro","fromEmail":"lucasseikioshiro@gmail.com","sentAt":"2025-04-16T16:02:19Z","receivedAt":"2025-04-16T16:02:34Z","isPatch":true,"sender":{"key":"lucasseikioshiro@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12701580?v=4"},"body":"\n> Nit, not worth a reroll: historic information like this is always a nice\n> addition to the commit message so that other people don't have to dig\n> into history themselves to figure out why the field isn't used anymore.\n\nOoops, sorry\n\n> The patch looks obviously good to me, thanks!\n\nThank you for reviewing another patch of mine!\n\n\n\n"}]}