git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC PATCH] revision: remove log_reencode field from rev_info

From
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date
Apr 14, 2025, 15:14 UTC
Message-ID
<20250414151438.22232-1-lucasseikioshiro@gmail.com>
Remove the log_reencode field from struct rev-info, as it is not used.
Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---
Just a simple cleanup patch removing this unused field.

When I was working in a previous patchset (this: https://lore.kernel.org/git/20250303220029.10716-1-lucasseikioshiro@gmail.com/) I noticed that this field wasn't used anywhere in the code.

I also saw that it hasn't been used since it's introduction in 2006, in commit 52883fb.

 revision.h | 1 -
 1 file changed, 1 deletion(-)
diff --git a/revision.h b/revision.h
index 71e984c452..87f8d798c2 100644
--- a/revision.h
+++ b/revision.h
@@ -292,7 +292,6 @@ struct rev_info {
 	struct string_list *ref_message_ids;
 	int		add_signoff;
 	const char	*extra_headers;
-	const char	*log_reencode;
 	const char	*subject_prefix;
 	int		patch_name_max;
 	int		no_inline;
-- 
2.39.5 (Apple Git-154)
Next: Patrick Steinhardt
Message 1 of 3 in “revision: remove log_reencode field from rev_info”
  1. revision: remove log_reencode field from rev_infoLucas Seiki Oshiro, Apr 14, 2025
  2. Patrick SteinhardtApr 16, 2025
  3. Lucas Seiki OshiroApr 16, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.