Re: [GSoC PATCH] revision: remove log_reencode field from rev_info

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 16, 2025, 08:54 UTC
Message-ID: <Z_9wQLTtj9t45Wjj@pks.im>
In-Reply-To: <20250414151438.22232-1-lucasseikioshiro@gmail.com>

On Mon, Apr 14, 2025 at 12:14:38PM -0300, Lucas Seiki Oshiro wrote:

Show 13 quoted lines

> Remove the log_reencode field from struct rev-info, as it is not used.
> 
> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
> ---
> 
> Just a simple cleanup patch removing this unused field.
> 
> When I was working in a previous patchset (this:
> https://lore.kernel.org/git/20250303220029.10716-1-lucasseikioshiro@gmail.com/)
> I noticed that this field wasn't used anywhere in the code.
> 
> I also saw that it hasn't been used since it's introduction in 2006, in
> commit 52883fb.

Nit, not worth a reroll: historic information like this is always a nice addition to the commit message so that other people don't have to dig into history themselves to figure out why the field isn't used anymore.

Show 15 quoted lines

>  revision.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/revision.h b/revision.h
> index 71e984c452..87f8d798c2 100644
> --- a/revision.h
> +++ b/revision.h
> @@ -292,7 +292,6 @@ struct rev_info {
>  	struct string_list *ref_message_ids;
>  	int		add_signoff;
>  	const char	*extra_headers;
> -	const char	*log_reencode;
>  	const char	*subject_prefix;
>  	int		patch_name_max;
>  	int		no_inline;

The patch looks obviously good to me, thanks!

Patrick