threads / patch / 58821

patchMakefile: suppress macOS deprecation warning

Subject: [PATCH] Makefile: suppress macOS deprecation warning

## tl;dr

5 messages between Nov 19, 2022 and Dec 1, 2022. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Stefan Sundin via GitGitGadget· Nov 19, 2022, 20:06 UTC · lore

From: Stefan Sundin <git@stefansundin.com>

Compiling git on macOS 13 emits the following deprecation warning:

        CC compat/fsmonitor/fsm-listen-darwin.o
    compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
            FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
            ^
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
    FSEventStreamScheduleWithRunLoop(
    ^
    1 warning generated.

Setting a minimum macOS version will suppress this deprecation warning. Using a version lower than 10.13 will cause other warning messages to be emitted.

Signed-off-by: Stefan Sundin <git@stefansundin.com>
---
    Makefile: suppress macOS deprecation warning

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1422%2Fstefansundin%2Fmacosx-version-min-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1422/stefansundin/macosx-version-min-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1422

 Makefile | 1 +
 1 file changed, 1 insertion(+)

Show changes to Makefile +1 −0

diff --git a/Makefile b/Makefile
index 4927379184c..8a729efd2d1 100644
--- a/Makefile
+++ b/Makefile
@@ -1430,6 +1430,7 @@ ifneq (,$(SOCKLEN_T))
 endif
 
 ifeq ($(uname_S),Darwin)
+	BASIC_CFLAGS += -mmacosx-version-min=10.13
 	ifndef NO_FINK
 		ifeq ($(shell test -d /sw/lib && echo y),y)
 			BASIC_CFLAGS += -I/sw/include

base-commit: eea7033409a0ed713c78437fc76486983d211e25

-- 
gitgitgadget

Bagas Sanjaya· Nov 20, 2022, 01:48 UTC · re: Stefan Sundin via GitGitGadget · lore

Re: [PATCH] Makefile: suppress macOS deprecation warning

On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote:

Show 17 quoted lines

> From: Stefan Sundin <git@stefansundin.com>
> 
> Compiling git on macOS 13 emits the following deprecation warning:
> 
>         CC compat/fsmonitor/fsm-listen-darwin.o
>     compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
>             FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
>             ^
>     /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
>     FSEventStreamScheduleWithRunLoop(
>     ^
>     1 warning generated.
> 
> Setting a minimum macOS version will suppress this deprecation warning.
> Using a version lower than 10.13 will cause other warning messages to
> be emitted.
>

Why don't instead follow the suggestion on the warning message (FSEventStreamSetDispatchQueue) instead?

-- 
An old man doll... just what I always wanted! - Clara

Stefan Sundin· Nov 20, 2022, 02:14 UTC · re: Bagas Sanjaya · lore

Re: [PATCH] Makefile: suppress macOS deprecation warning

On Sat, Nov 19, 2022 at 5:48 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:

Show 25 quoted lines

>
> On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote:
> > From: Stefan Sundin <git@stefansundin.com>
> >
> > Compiling git on macOS 13 emits the following deprecation warning:
> >
> >         CC compat/fsmonitor/fsm-listen-darwin.o
> >     compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
> >             FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
> >             ^
> >     /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
> >     FSEventStreamScheduleWithRunLoop(
> >     ^
> >     1 warning generated.
> >
> > Setting a minimum macOS version will suppress this deprecation warning.
> > Using a version lower than 10.13 will cause other warning messages to
> > be emitted.
> >
>
> Why don't instead follow the suggestion on the warning message
> (FSEventStreamSetDispatchQueue) instead?
>
> --
> An old man doll... just what I always wanted! - Clara

You are right, Bagas. I assumed, without actually looking it up, that the new function had a higher-than-acceptable minimum macOS version requirement. It turns out that the new function was added in 10.6 which is far better than requiring 10.13.

Please disregard this patch and I will attempt to update the code to use the new function instead.

Bagas Sanjaya· Nov 20, 2022, 12:29 UTC · re: Stefan Sundin · lore

Re: [PATCH] Makefile: suppress macOS deprecation warning

On 11/20/22 09:14, Stefan Sundin wrote:

Show 7 quoted lines

> You are right, Bagas. I assumed, without actually looking it up, that
> the new function had a higher-than-acceptable minimum macOS version
> requirement. It turns out that the new function was added in 10.6
> which is far better than requiring 10.13.
> 
> Please disregard this patch and I will attempt to update the code to
> use the new function instead.

OK. But unfortunately, I don't have any macOS machines handy, so I can't test your future patch.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Jeff Hostetler· Dec 1, 2022, 18:53 UTC · re: Bagas Sanjaya · lore

Re: [PATCH] Makefile: suppress macOS deprecation warning

On 11/20/22 7:29 AM, Bagas Sanjaya wrote:

Show 14 quoted lines

> On 11/20/22 09:14, Stefan Sundin wrote:
>> You are right, Bagas. I assumed, without actually looking it up, that
>> the new function had a higher-than-acceptable minimum macOS version
>> requirement. It turns out that the new function was added in 10.6
>> which is far better than requiring 10.13.
>>
>> Please disregard this patch and I will attempt to update the code to
>> use the new function instead.
> 
> OK. But unfortunately, I don't have any macOS machines handy, so I can't
> test your future patch.
> 
> Thanks.
>

As I mentioned in another thread, I'm working on a solution for this deprecated function. As soon the CI builds finish I'll submit it.

Jeff