{"thread":{"id":"58821","subject":"[PATCH] Makefile: suppress macOS deprecation warning","startedAt":"2022-11-19T20:06:56Z","lastAt":"2022-12-01T18:53:49Z","messageCount":5,"participants":["Stefan Sundin via GitGitGadget","Bagas Sanjaya","Stefan Sundin","Jeff Hostetler"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"467594","messageId":"pull.1422.git.1668888407433.gitgitgadget@gmail.com","threadId":"58821","inReplyTo":null,"subject":"[PATCH] Makefile: suppress macOS deprecation warning","fromName":"Stefan Sundin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-11-19T20:06:47Z","receivedAt":"2022-11-19T20:06:56Z","isPatch":true,"sender":{"key":"git@stefansundin.com","avatar":null},"body":"From: Stefan Sundin <git@stefansundin.com>\n\nCompiling git on macOS 13 emits the following deprecation warning:\n\n        CC compat/fsmonitor/fsm-listen-darwin.o\n    compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]\n            FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);\n            ^\n    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here\n    FSEventStreamScheduleWithRunLoop(\n    ^\n    1 warning generated.\n\nSetting a minimum macOS version will suppress this deprecation warning.\nUsing a version lower than 10.13 will cause other warning messages to\nbe emitted.\n\nSigned-off-by: Stefan Sundin <git@stefansundin.com>\n---\n    Makefile: suppress macOS deprecation warning\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1422%2Fstefansundin%2Fmacosx-version-min-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1422/stefansundin/macosx-version-min-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1422\n\n Makefile | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Makefile b/Makefile\nindex 4927379184c..8a729efd2d1 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1430,6 +1430,7 @@ ifneq (,$(SOCKLEN_T))\n endif\n \n ifeq ($(uname_S),Darwin)\n+\tBASIC_CFLAGS += -mmacosx-version-min=10.13\n \tifndef NO_FINK\n \t\tifeq ($(shell test -d /sw/lib && echo y),y)\n \t\t\tBASIC_CFLAGS += -I/sw/include\n\nbase-commit: eea7033409a0ed713c78437fc76486983d211e25\n-- \ngitgitgadget\n"},{"id":"467603","messageId":"a3cfe081-1e68-edda-b797-e68356988046@gmail.com","threadId":"58821","inReplyTo":"pull.1422.git.1668888407433.gitgitgadget@gmail.com","subject":"Re: [PATCH] Makefile: suppress macOS deprecation warning","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2022-11-20T01:48:25Z","receivedAt":"2022-11-20T01:48:32Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote:\n> From: Stefan Sundin <git@stefansundin.com>\n> \n> Compiling git on macOS 13 emits the following deprecation warning:\n> \n>         CC compat/fsmonitor/fsm-listen-darwin.o\n>     compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]\n>             FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);\n>             ^\n>     /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here\n>     FSEventStreamScheduleWithRunLoop(\n>     ^\n>     1 warning generated.\n> \n> Setting a minimum macOS version will suppress this deprecation warning.\n> Using a version lower than 10.13 will cause other warning messages to\n> be emitted.\n> \n\nWhy don't instead follow the suggestion on the warning message\n(FSEventStreamSetDispatchQueue) instead?\n\n-- \nAn old man doll... just what I always wanted! - Clara\n\n"},{"id":"467604","messageId":"CAMDaVWGFi6CD+MMbWG=N57yyb8=k6AouB5h33NkKvs2q4UxRmQ@mail.gmail.com","threadId":"58821","inReplyTo":"a3cfe081-1e68-edda-b797-e68356988046@gmail.com","subject":"Re: [PATCH] Makefile: suppress macOS deprecation warning","fromName":"Stefan Sundin","fromEmail":"git@stefansundin.com","sentAt":"2022-11-20T02:14:36Z","receivedAt":"2022-11-20T02:19:37Z","isPatch":true,"sender":{"key":"git@stefansundin.com","avatar":null},"body":"On Sat, Nov 19, 2022 at 5:48 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:\n>\n> On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote:\n> > From: Stefan Sundin <git@stefansundin.com>\n> >\n> > Compiling git on macOS 13 emits the following deprecation warning:\n> >\n> >         CC compat/fsmonitor/fsm-listen-darwin.o\n> >     compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]\n> >             FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);\n> >             ^\n> >     /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here\n> >     FSEventStreamScheduleWithRunLoop(\n> >     ^\n> >     1 warning generated.\n> >\n> > Setting a minimum macOS version will suppress this deprecation warning.\n> > Using a version lower than 10.13 will cause other warning messages to\n> > be emitted.\n> >\n>\n> Why don't instead follow the suggestion on the warning message\n> (FSEventStreamSetDispatchQueue) instead?\n>\n> --\n> An old man doll... just what I always wanted! - Clara\n\nYou are right, Bagas. I assumed, without actually looking it up, that\nthe new function had a higher-than-acceptable minimum macOS version\nrequirement. It turns out that the new function was added in 10.6\nwhich is far better than requiring 10.13.\n\nPlease disregard this patch and I will attempt to update the code to\nuse the new function instead.\n"},{"id":"467619","messageId":"4e0ecd76-8bd3-c1c4-69ca-a2de4886f491@gmail.com","threadId":"58821","inReplyTo":"CAMDaVWGFi6CD+MMbWG=N57yyb8=k6AouB5h33NkKvs2q4UxRmQ@mail.gmail.com","subject":"Re: [PATCH] Makefile: suppress macOS deprecation warning","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2022-11-20T12:29:15Z","receivedAt":"2022-11-20T12:29:22Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 11/20/22 09:14, Stefan Sundin wrote:\n> You are right, Bagas. I assumed, without actually looking it up, that\n> the new function had a higher-than-acceptable minimum macOS version\n> requirement. It turns out that the new function was added in 10.6\n> which is far better than requiring 10.13.\n> \n> Please disregard this patch and I will attempt to update the code to\n> use the new function instead.\n\nOK. But unfortunately, I don't have any macOS machines handy, so I can't\ntest your future patch.\n\nThanks.\n\n-- \nAn old man doll... just what I always wanted! - Clara\n\n"},{"id":"468337","messageId":"7ef9ed2b-101d-ab00-3126-3b23990b9b19@jeffhostetler.com","threadId":"58821","inReplyTo":"4e0ecd76-8bd3-c1c4-69ca-a2de4886f491@gmail.com","subject":"Re: [PATCH] Makefile: suppress macOS deprecation warning","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2022-12-01T18:53:41Z","receivedAt":"2022-12-01T18:53:49Z","isPatch":true,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 11/20/22 7:29 AM, Bagas Sanjaya wrote:\n> On 11/20/22 09:14, Stefan Sundin wrote:\n>> You are right, Bagas. I assumed, without actually looking it up, that\n>> the new function had a higher-than-acceptable minimum macOS version\n>> requirement. It turns out that the new function was added in 10.6\n>> which is far better than requiring 10.13.\n>>\n>> Please disregard this patch and I will attempt to update the code to\n>> use the new function instead.\n> \n> OK. But unfortunately, I don't have any macOS machines handy, so I can't\n> test your future patch.\n> \n> Thanks.\n> \n\nAs I mentioned in another thread, I'm working on a solution\nfor this deprecated function.  As soon the CI builds finish\nI'll submit it.\n\nJeff\n"}]}