git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: suppress macOS deprecation warning

From
SGStefan Sundin via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 19, 2022, 20:06 UTC
Message-ID
<pull.1422.git.1668888407433.gitgitgadget@gmail.com>
From: Stefan Sundin <git@stefansundin.com>
Compiling git on macOS 13 emits the following deprecation warning:
        CC compat/fsmonitor/fsm-listen-darwin.o
    compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
            FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
            ^
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
    FSEventStreamScheduleWithRunLoop(
    ^
    1 warning generated.

Setting a minimum macOS version will suppress this deprecation warning. Using a version lower than 10.13 will cause other warning messages to be emitted.

Signed-off-by: Stefan Sundin <git@stefansundin.com>
---
    Makefile: suppress macOS deprecation warning
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1422%2Fstefansundin%2Fmacosx-version-min-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1422/stefansundin/macosx-version-min-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1422
 Makefile | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 4927379184c..8a729efd2d1 100644
--- a/Makefile
+++ b/Makefile
@@ -1430,6 +1430,7 @@ ifneq (,$(SOCKLEN_T))
 endif
 
 ifeq ($(uname_S),Darwin)
+	BASIC_CFLAGS += -mmacosx-version-min=10.13
 	ifndef NO_FINK
 		ifeq ($(shell test -d /sw/lib && echo y),y)
 			BASIC_CFLAGS += -I/sw/include

base-commit: eea7033409a0ed713c78437fc76486983d211e25
-- 
gitgitgadget
Next: Bagas Sanjaya
Message 1 of 5 in “Makefile: suppress macOS deprecation warning”
  1. Makefile: suppress macOS deprecation warningStefan Sundin via GitGitGadget, Nov 19, 2022
  2. Bagas SanjayaNov 20, 2022
  3. Stefan SundinNov 20, 2022
  4. Bagas SanjayaNov 20, 2022
  5. Jeff HostetlerDec 1, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.