Re: [PATCH] Makefile: suppress macOS deprecation warning

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Nov 20, 2022, 01:48 UTC
Message-ID: <a3cfe081-1e68-edda-b797-e68356988046@gmail.com>
In-Reply-To: <pull.1422.git.1668888407433.gitgitgadget@gmail.com>

On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote:

Show 17 quoted lines

> From: Stefan Sundin <git@stefansundin.com>
> 
> Compiling git on macOS 13 emits the following deprecation warning:
> 
>         CC compat/fsmonitor/fsm-listen-darwin.o
>     compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
>             FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
>             ^
>     /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
>     FSEventStreamScheduleWithRunLoop(
>     ^
>     1 warning generated.
> 
> Setting a minimum macOS version will suppress this deprecation warning.
> Using a version lower than 10.13 will cause other warning messages to
> be emitted.
>

Why don't instead follow the suggestion on the warning message (FSEventStreamSetDispatchQueue) instead?

-- 
An old man doll... just what I always wanted! - Clara