Re: [PATCH] Makefile: suppress macOS deprecation warning

From: Stefan Sundin <git@stefansundin.com>
Date: Nov 20, 2022, 02:14 UTC
Message-ID: <CAMDaVWGFi6CD+MMbWG=N57yyb8=k6AouB5h33NkKvs2q4UxRmQ@mail.gmail.com>
In-Reply-To: <a3cfe081-1e68-edda-b797-e68356988046@gmail.com>

On Sat, Nov 19, 2022 at 5:48 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:

Show 25 quoted lines

>
> On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote:
> > From: Stefan Sundin <git@stefansundin.com>
> >
> > Compiling git on macOS 13 emits the following deprecation warning:
> >
> >         CC compat/fsmonitor/fsm-listen-darwin.o
> >     compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
> >             FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
> >             ^
> >     /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
> >     FSEventStreamScheduleWithRunLoop(
> >     ^
> >     1 warning generated.
> >
> > Setting a minimum macOS version will suppress this deprecation warning.
> > Using a version lower than 10.13 will cause other warning messages to
> > be emitted.
> >
>
> Why don't instead follow the suggestion on the warning message
> (FSEventStreamSetDispatchQueue) instead?
>
> --
> An old man doll... just what I always wanted! - Clara

You are right, Bagas. I assumed, without actually looking it up, that the new function had a higher-than-acceptable minimum macOS version requirement. It turns out that the new function was added in 10.6 which is far better than requiring 10.13.

Please disregard this patch and I will attempt to update the code to use the new function instead.