threads / patch / 50026

patcht9902: 'send-email' test case requires PERL

Subject: [PATCH 1/1] t9902: 'send-email' test case requires PERL

## tl;dr

6 messages between Dec 13, 2018 and Dec 13, 2018. Diffs are folded; open one to read it.

replies: 5people: 2as markdown or json

Johannes Schindelin via GitGitGadget· Dec 13, 2018, 13:01 UTC · lore

[PATCH 0/1] Fix regression in t9902 with NO_PERL

The oneline notwithstanding,13374987dd (completion: use _gitcompbuiltin for format-patch, 2018-11-03) changed also the way send-email options are completed, by asking the git send-email command itself what options it offers.

Necessarily, this must fail when built with NO_PERL because send-email itself is a Perl script. Which means that we need the PERL prerequisite for the send-email test case in t9902.

Johannes Schindelin (1):
  t9902: 'send-email' test case requires PERL
 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/99
-- 
gitgitgadget
Johannes Schindelin via GitGitGadget· Dec 13, 2018, 13:01 UTC · re: Johannes Schindelin via GitGitGadget · lore
From: Johannes Schindelin <johannes.schindelin@gmx.de>

With NO_PERL, the `git send-email` script errors out with code 128, mentioning that Git was built without Perl support.

Therefore, when the completion tries to ask for possible completions via `git send-email --git-completion-helper`, it won't provide what is necessary for that test case to pass.

So let's mark it with the PERL prerequisite.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/t9902-completion.sh +1 −1
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index d01ad8eb25..137fdc9bd5 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -1539,7 +1539,7 @@ test_expect_success 'complete tree filename with metacharacters' '
 	EOF
 '
 
-test_expect_success 'send-email' '
+test_expect_success PERL 'send-email' '
 	test_completion "git send-email --cov" "--cover-letter " &&
 	test_completion "git send-email ma" "master "
 '

-- 
gitgitgadget
SZEDER Gábor· Dec 13, 2018, 13:27 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH 0/1] Fix regression in t9902 with NO_PERL

On Thu, Dec 13, 2018 at 05:01:11AM -0800, Johannes Schindelin via GitGitGadget wrote:
Show 8 quoted lines
> The oneline notwithstanding,13374987dd (completion: use _gitcompbuiltin for
> format-patch, 2018-11-03) changed also the way send-email options are
> completed, by asking the git send-email command itself what options it
> offers.
> 
> Necessarily, this must fail when built with NO_PERL because send-email 
> itself is a Perl script. Which means that we need the PERL prerequisite for
> the send-email test case in t9902.

I find this text in the cover letter to be a better commit message than the text in the patch itself, because mentions when it broke and clearly mentions why it broke.

Show 13 quoted lines
> Johannes Schindelin (1):
>   t9902: 'send-email' test case requires PERL
> 
>  t/t9902-completion.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
> Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/99
> -- 
> gitgitgadget
Johannes Schindelin· Dec 13, 2018, 13:52 UTC · re: SZEDER Gábor · lore

Re: [PATCH 0/1] Fix regression in t9902 with NO_PERL

Hi Gábor,
On Thu, 13 Dec 2018, SZEDER Gábor wrote:
Show 13 quoted lines
> On Thu, Dec 13, 2018 at 05:01:11AM -0800, Johannes Schindelin via GitGitGadget wrote:
> > The oneline notwithstanding,13374987dd (completion: use
> > _gitcompbuiltin for format-patch, 2018-11-03) changed also the way
> > send-email options are completed, by asking the git send-email command
> > itself what options it offers.
> > 
> > Necessarily, this must fail when built with NO_PERL because send-email
> > itself is a Perl script. Which means that we need the PERL
> > prerequisite for the send-email test case in t9902.
> 
> I find this text in the cover letter to be a better commit message than
> the text in the patch itself, because mentions when it broke and clearly
> mentions why it broke.
Okay, I replaced the commit message.

Ciao, Dscho

Show 15 quoted lines
> 
> > Johannes Schindelin (1):
> >   t9902: 'send-email' test case requires PERL
> > 
> >  t/t9902-completion.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > 
> > base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
> > Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1
> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1
> > Pull-Request: https://github.com/gitgitgadget/git/pull/99
> > -- 
> > gitgitgadget
>
Johannes Schindelin via GitGitGadget· Dec 13, 2018, 14:04 UTC · re: Johannes Schindelin via GitGitGadget · lore

[PATCH v2 0/1] Fix regression in t9902 with NO_PERL

The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin for format-patch, 2018-11-03) changed also the way send-email options are completed, by asking the git send-email command itself what options it offers.

Necessarily, this must fail when built with NO_PERL because send-email itself is a Perl script. Which means that we need the PERL prerequisite for the send-email test case in t9902.

Changes since v1:
 * replaced the commit message by the cover letter, as it was deemed to be
   more informative.
Johannes Schindelin (1):
  t9902: 'send-email' test case requires PERL
 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/99
Range-diff vs v1:
 1:  32e6bf2dd3 ! 1:  8e3ddff2c7 t9902: 'send-email' test case requires PERL
     @@ -2,14 +2,14 @@
      
          t9902: 'send-email' test case requires PERL
      
     -    With NO_PERL, the `git send-email` script errors out with code 128,
     -    mentioning that Git was built without Perl support.
     +    The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin
     +    for format-patch, 2018-11-03) changed also the way send-email options
     +    are completed, by asking the git send-email command itself what options
     +    it offers.
      
     -    Therefore, when the completion tries to ask for possible completions via
     -    `git send-email --git-completion-helper`, it won't provide what is
     -    necessary for that test case to pass.
     -
     -    So let's mark it with the PERL prerequisite.
     +    Necessarily, this must fail when built with NO_PERL because send-email
     +    itself is a Perl script. Which means that we need the PERL prerequisite
     +    for the send-email test case in t9902.
      
          Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
      
-- 
gitgitgadget
Johannes Schindelin via GitGitGadget· Dec 13, 2018, 14:04 UTC · re: Johannes Schindelin via GitGitGadget · lore

[PATCH v2 1/1] t9902: 'send-email' test case requires PERL

From: Johannes Schindelin <johannes.schindelin@gmx.de>

The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin for format-patch, 2018-11-03) changed also the way send-email options are completed, by asking the git send-email command itself what options it offers.

Necessarily, this must fail when built with NO_PERL because send-email itself is a Perl script. Which means that we need the PERL prerequisite for the send-email test case in t9902.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/t9902-completion.sh +1 −1
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index d01ad8eb25..137fdc9bd5 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -1539,7 +1539,7 @@ test_expect_success 'complete tree filename with metacharacters' '
 	EOF
 '
 
-test_expect_success 'send-email' '
+test_expect_success PERL 'send-email' '
 	test_completion "git send-email --cov" "--cover-letter " &&
 	test_completion "git send-email ma" "master "
 '

-- 
gitgitgadget

← back to recent threads