git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] t9902: 'send-email' test case requires PERL

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 13, 2018, 13:01 UTC
Message-ID
<32e6bf2dd37a4a4e43211cf7efa4656b2a15ce6d.1544706070.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.99.git.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

With NO_PERL, the `git send-email` script errors out with code 128, mentioning that Git was built without Perl support.

Therefore, when the completion tries to ask for possible completions via `git send-email --git-completion-helper`, it won't provide what is necessary for that test case to pass.

So let's mark it with the PERL prerequisite.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index d01ad8eb25..137fdc9bd5 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -1539,7 +1539,7 @@ test_expect_success 'complete tree filename with metacharacters' '
 	EOF
 '
 
-test_expect_success 'send-email' '
+test_expect_success PERL 'send-email' '
 	test_completion "git send-email --cov" "--cover-letter " &&
 	test_completion "git send-email ma" "master "
 '
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: SZEDER Gábor
Message 2 of 6 in “Fix regression in t9902 with NO_PERL”
  1. 0/1 Fix regression in t9902 with NO_PERLJohannes Schindelin via GitGitGadget, Dec 13, 2018
  2. 1/1 t9902: 'send-email' test case requires PERLJohannes Schindelin via GitGitGadget, Dec 13, 2018
  3. SZEDER GáborDec 13, 2018
  4. Johannes SchindelinDec 13, 2018
  5. 0/1 Fix regression in t9902 with NO_PERLJohannes Schindelin via GitGitGadget, Dec 13, 2018
  6. 1/1 t9902: 'send-email' test case requires PERLJohannes Schindelin via GitGitGadget, Dec 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.