{"thread":{"id":"50026","subject":"[PATCH 1/1] t9902: 'send-email' test case requires PERL","startedAt":"2018-12-13T13:01:15Z","lastAt":"2018-12-13T14:04:24Z","messageCount":6,"participants":["Johannes Schindelin via GitGitGadget","SZEDER Gábor","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"365242","messageId":"32e6bf2dd37a4a4e43211cf7efa4656b2a15ce6d.1544706070.git.gitgitgadget@gmail.com","threadId":"50026","inReplyTo":"pull.99.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] t9902: 'send-email' test case requires PERL","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-12-13T13:01:13Z","receivedAt":"2018-12-13T13:01:15Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nWith NO_PERL, the `git send-email` script errors out with code 128,\nmentioning that Git was built without Perl support.\n\nTherefore, when the completion tries to ask for possible completions via\n`git send-email --git-completion-helper`, it won't provide what is\nnecessary for that test case to pass.\n\nSo let's mark it with the PERL prerequisite.\n\nSigned-off-by: Johannes Schindelin \n---\n t/t9902-completion.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t9902-completion.sh b/t/t9902-completion.sh\nindex d01ad8eb25..137fdc9bd5 100755\n--- a/t/t9902-completion.sh\n+++ b/t/t9902-completion.sh\n@@ -1539,7 +1539,7 @@ test_expect_success 'complete tree filename with metacharacters' '\n \tEOF\n '\n \n-test_expect_success 'send-email' '\n+test_expect_success PERL 'send-email' '\n \ttest_completion \"git send-email --cov\" \"--cover-letter \" &&\n \ttest_completion \"git send-email ma\" \"master \"\n '\n-- \ngitgitgadget\n"},{"id":"365243","messageId":"pull.99.git.gitgitgadget@gmail.com","threadId":"50026","inReplyTo":null,"subject":"[PATCH 0/1] Fix regression in t9902 with NO_PERL","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-12-13T13:01:11Z","receivedAt":"2018-12-13T13:01:17Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"The oneline notwithstanding,13374987dd (completion: use _gitcompbuiltin for\nformat-patch, 2018-11-03) changed also the way send-email options are\ncompleted, by asking the git send-email command itself what options it\noffers.\n\nNecessarily, this must fail when built with NO_PERL because send-email \nitself is a Perl script. Which means that we need the PERL prerequisite for\nthe send-email test case in t9902.\n\nJohannes Schindelin (1):\n t9902: 'send-email' test case requires PERL\n\n t/t9902-completion.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 5d826e972970a784bd7a7bdf587512510097b8c7\nPublished-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/99\n-- \ngitgitgadget\n"},{"id":"365248","messageId":"20181213132707.GX30222@szeder.dev","threadId":"50026","inReplyTo":"pull.99.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/1] Fix regression in t9902 with NO_PERL","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2018-12-13T13:27:07Z","receivedAt":"2018-12-13T13:27:13Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Thu, Dec 13, 2018 at 05:01:11AM -0800, Johannes Schindelin via GitGitGadget wrote:\n> The oneline notwithstanding,13374987dd (completion: use _gitcompbuiltin for\n> format-patch, 2018-11-03) changed also the way send-email options are\n> completed, by asking the git send-email command itself what options it\n> offers.\n> \n> Necessarily, this must fail when built with NO_PERL because send-email \n> itself is a Perl script. Which means that we need the PERL prerequisite for\n> the send-email test case in t9902.\n\nI find this text in the cover letter to be a better commit message\nthan the text in the patch itself, because mentions when it broke and\nclearly mentions why it broke.\n\n> Johannes Schindelin (1):\n> t9902: 'send-email' test case requires PERL\n> \n> t/t9902-completion.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> \n> base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7\n> Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/99\n> -- \n> gitgitgadget\n"},{"id":"365251","messageId":"nycvar.QRO.7.76.6.1812131452020.43@tvgsbejvaqbjf.bet","threadId":"50026","inReplyTo":"20181213132707.GX30222@szeder.dev","subject":"Re: [PATCH 0/1] Fix regression in t9902 with NO_PERL","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-12-13T13:52:44Z","receivedAt":"2018-12-13T13:53:06Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Gábor,\n\nOn Thu, 13 Dec 2018, SZEDER Gábor wrote:\n\n> On Thu, Dec 13, 2018 at 05:01:11AM -0800, Johannes Schindelin via GitGitGadget wrote:\n> > The oneline notwithstanding,13374987dd (completion: use\n> > _gitcompbuiltin for format-patch, 2018-11-03) changed also the way\n> > send-email options are completed, by asking the git send-email command\n> > itself what options it offers.\n> > \n> > Necessarily, this must fail when built with NO_PERL because send-email\n> > itself is a Perl script. Which means that we need the PERL\n> > prerequisite for the send-email test case in t9902.\n> \n> I find this text in the cover letter to be a better commit message than\n> the text in the patch itself, because mentions when it broke and clearly\n> mentions why it broke.\n\nOkay, I replaced the commit message.\n\nCiao,\nDscho\n\n> \n> > Johannes Schindelin (1):\n> > t9902: 'send-email' test case requires PERL\n> > \n> > t/t9902-completion.sh | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > \n> > base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7\n> > Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1\n> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1\n> > Pull-Request: https://github.com/gitgitgadget/git/pull/99\n> > -- \n> > gitgitgadget\n> "},{"id":"365253","messageId":"8e3ddff2c7d2f76a565de33ab638b0778155f2ad.1544709857.git.gitgitgadget@gmail.com","threadId":"50026","inReplyTo":"pull.99.v2.git.gitgitgadget@gmail.com","subject":"[PATCH v2 1/1] t9902: 'send-email' test case requires PERL","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-12-13T14:04:19Z","receivedAt":"2018-12-13T14:04:22Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nThe oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin\nfor format-patch, 2018-11-03) changed also the way send-email options\nare completed, by asking the git send-email command itself what options\nit offers.\n\nNecessarily, this must fail when built with NO_PERL because send-email\nitself is a Perl script. Which means that we need the PERL prerequisite\nfor the send-email test case in t9902.\n\nSigned-off-by: Johannes Schindelin \n---\n t/t9902-completion.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t9902-completion.sh b/t/t9902-completion.sh\nindex d01ad8eb25..137fdc9bd5 100755\n--- a/t/t9902-completion.sh\n+++ b/t/t9902-completion.sh\n@@ -1539,7 +1539,7 @@ test_expect_success 'complete tree filename with metacharacters' '\n \tEOF\n '\n \n-test_expect_success 'send-email' '\n+test_expect_success PERL 'send-email' '\n \ttest_completion \"git send-email --cov\" \"--cover-letter \" &&\n \ttest_completion \"git send-email ma\" \"master \"\n '\n-- \ngitgitgadget\n"},{"id":"365254","messageId":"pull.99.v2.git.gitgitgadget@gmail.com","threadId":"50026","inReplyTo":"pull.99.git.gitgitgadget@gmail.com","subject":"[PATCH v2 0/1] Fix regression in t9902 with NO_PERL","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-12-13T14:04:18Z","receivedAt":"2018-12-13T14:04:24Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin for\nformat-patch, 2018-11-03) changed also the way send-email options are\ncompleted, by asking the git send-email command itself what options it\noffers.\n\nNecessarily, this must fail when built with NO_PERL because send-email \nitself is a Perl script. Which means that we need the PERL prerequisite for\nthe send-email test case in t9902.\n\nChanges since v1:\n\n * replaced the commit message by the cover letter, as it was deemed to be\n more informative.\n\nJohannes Schindelin (1):\n t9902: 'send-email' test case requires PERL\n\n t/t9902-completion.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 5d826e972970a784bd7a7bdf587512510097b8c7\nPublished-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v2\nPull-Request: https://github.com/gitgitgadget/git/pull/99\n\nRange-diff vs v1:\n\n 1: 32e6bf2dd3 ! 1: 8e3ddff2c7 t9902: 'send-email' test case requires PERL\n @@ -2,14 +2,14 @@\n \n t9902: 'send-email' test case requires PERL\n \n - With NO_PERL, the `git send-email` script errors out with code 128,\n - mentioning that Git was built without Perl support.\n + The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin\n + for format-patch, 2018-11-03) changed also the way send-email options\n + are completed, by asking the git send-email command itself what options\n + it offers.\n \n - Therefore, when the completion tries to ask for possible completions via\n - `git send-email --git-completion-helper`, it won't provide what is\n - necessary for that test case to pass.\n -\n - So let's mark it with the PERL prerequisite.\n + Necessarily, this must fail when built with NO_PERL because send-email\n + itself is a Perl script. Which means that we need the PERL prerequisite\n + for the send-email test case in t9902.\n \n Signed-off-by: Johannes Schindelin \n \n\n-- \ngitgitgadget\n"}]}