git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/1] t9902: 'send-email' test case requires PERL

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 13, 2018, 14:04 UTC
Message-ID
<8e3ddff2c7d2f76a565de33ab638b0778155f2ad.1544709857.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.99.v2.git.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin for format-patch, 2018-11-03) changed also the way send-email options are completed, by asking the git send-email command itself what options it offers.

Necessarily, this must fail when built with NO_PERL because send-email itself is a Perl script. Which means that we need the PERL prerequisite for the send-email test case in t9902.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index d01ad8eb25..137fdc9bd5 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -1539,7 +1539,7 @@ test_expect_success 'complete tree filename with metacharacters' '
 	EOF
 '
 
-test_expect_success 'send-email' '
+test_expect_success PERL 'send-email' '
 	test_completion "git send-email --cov" "--cover-letter " &&
 	test_completion "git send-email ma" "master "
 '
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadget
Message 6 of 6 in “Fix regression in t9902 with NO_PERL”
  1. 0/1 Fix regression in t9902 with NO_PERLJohannes Schindelin via GitGitGadget, Dec 13, 2018
  2. 1/1 t9902: 'send-email' test case requires PERLJohannes Schindelin via GitGitGadget, Dec 13, 2018
  3. SZEDER GáborDec 13, 2018
  4. Johannes SchindelinDec 13, 2018
  5. 0/1 Fix regression in t9902 with NO_PERLJohannes Schindelin via GitGitGadget, Dec 13, 2018
  6. 1/1 t9902: 'send-email' test case requires PERLJohannes Schindelin via GitGitGadget, Dec 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.