# [PATCH 1/1] t9902: 'send-email' test case requires PERL 6 messages from 2018-12-13 to 2018-12-13. Participants: Johannes Schindelin via GitGitGadget, SZEDER Gábor, Johannes Schindelin. Thread: https://gitlist.dev/t/50026 ## Johannes Schindelin via GitGitGadget, 2018-12-13 13:01 Subject: [PATCH 1/1] t9902: 'send-email' test case requires PERL Message-ID: <32e6bf2dd37a4a4e43211cf7efa4656b2a15ce6d.1544706070.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/32e6bf2dd37a4a4e43211cf7efa4656b2a15ce6d.1544706070.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Johannes Schindelin With NO_PERL, the `git send-email` script errors out with code 128, mentioning that Git was built without Perl support. Therefore, when the completion tries to ask for possible completions via `git send-email --git-completion-helper`, it won't provide what is necessary for that test case to pass. So let's mark it with the PERL prerequisite. Signed-off-by: Johannes Schindelin --- t/t9902-completion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index d01ad8eb25..137fdc9bd5 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -1539,7 +1539,7 @@ test_expect_success 'complete tree filename with metacharacters' ' EOF ' -test_expect_success 'send-email' ' +test_expect_success PERL 'send-email' ' test_completion "git send-email --cov" "--cover-letter " && test_completion "git send-email ma" "master " ' -- gitgitgadget ``` ## Johannes Schindelin via GitGitGadget, 2018-12-13 13:01 Subject: [PATCH 0/1] Fix regression in t9902 with NO_PERL Message-ID: URL: https://gitlist.dev/e/pull.99.git.gitgitgadget%40gmail.com ``` The oneline notwithstanding,13374987dd (completion: use _gitcompbuiltin for format-patch, 2018-11-03) changed also the way send-email options are completed, by asking the git send-email command itself what options it offers. Necessarily, this must fail when built with NO_PERL because send-email itself is a Perl script. Which means that we need the PERL prerequisite for the send-email test case in t9902. Johannes Schindelin (1): t9902: 'send-email' test case requires PERL t/t9902-completion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7 Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/99 -- gitgitgadget ``` ## SZEDER Gábor, 2018-12-13 13:27 Subject: Re: [PATCH 0/1] Fix regression in t9902 with NO_PERL Message-ID: <20181213132707.GX30222@szeder.dev> URL: https://gitlist.dev/e/20181213132707.GX30222%40szeder.dev In-Reply-To: ``` On Thu, Dec 13, 2018 at 05:01:11AM -0800, Johannes Schindelin via GitGitGadget wrote: > The oneline notwithstanding,13374987dd (completion: use _gitcompbuiltin for > format-patch, 2018-11-03) changed also the way send-email options are > completed, by asking the git send-email command itself what options it > offers. > > Necessarily, this must fail when built with NO_PERL because send-email > itself is a Perl script. Which means that we need the PERL prerequisite for > the send-email test case in t9902. I find this text in the cover letter to be a better commit message than the text in the patch itself, because mentions when it broke and clearly mentions why it broke. > Johannes Schindelin (1): > t9902: 'send-email' test case requires PERL > > t/t9902-completion.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7 > Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/99 > -- > gitgitgadget ``` ## Johannes Schindelin, 2018-12-13 13:52 Subject: Re: [PATCH 0/1] Fix regression in t9902 with NO_PERL Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.1812131452020.43%40tvgsbejvaqbjf.bet In-Reply-To: <20181213132707.GX30222@szeder.dev> ``` Hi Gábor, On Thu, 13 Dec 2018, SZEDER Gábor wrote: > On Thu, Dec 13, 2018 at 05:01:11AM -0800, Johannes Schindelin via GitGitGadget wrote: > > The oneline notwithstanding,13374987dd (completion: use > > _gitcompbuiltin for format-patch, 2018-11-03) changed also the way > > send-email options are completed, by asking the git send-email command > > itself what options it offers. > > > > Necessarily, this must fail when built with NO_PERL because send-email > > itself is a Perl script. Which means that we need the PERL > > prerequisite for the send-email test case in t9902. > > I find this text in the cover letter to be a better commit message than > the text in the patch itself, because mentions when it broke and clearly > mentions why it broke. Okay, I replaced the commit message. Ciao, Dscho > > > Johannes Schindelin (1): > > t9902: 'send-email' test case requires PERL > > > > t/t9902-completion.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7 > > Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1 > > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1 > > Pull-Request: https://github.com/gitgitgadget/git/pull/99 > > -- > > gitgitgadget > ``` ## Johannes Schindelin via GitGitGadget, 2018-12-13 14:04 Subject: [PATCH v2 1/1] t9902: 'send-email' test case requires PERL Message-ID: <8e3ddff2c7d2f76a565de33ab638b0778155f2ad.1544709857.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/8e3ddff2c7d2f76a565de33ab638b0778155f2ad.1544709857.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Johannes Schindelin The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin for format-patch, 2018-11-03) changed also the way send-email options are completed, by asking the git send-email command itself what options it offers. Necessarily, this must fail when built with NO_PERL because send-email itself is a Perl script. Which means that we need the PERL prerequisite for the send-email test case in t9902. Signed-off-by: Johannes Schindelin --- t/t9902-completion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index d01ad8eb25..137fdc9bd5 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -1539,7 +1539,7 @@ test_expect_success 'complete tree filename with metacharacters' ' EOF ' -test_expect_success 'send-email' ' +test_expect_success PERL 'send-email' ' test_completion "git send-email --cov" "--cover-letter " && test_completion "git send-email ma" "master " ' -- gitgitgadget ``` ## Johannes Schindelin via GitGitGadget, 2018-12-13 14:04 Subject: [PATCH v2 0/1] Fix regression in t9902 with NO_PERL Message-ID: URL: https://gitlist.dev/e/pull.99.v2.git.gitgitgadget%40gmail.com In-Reply-To: ``` The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin for format-patch, 2018-11-03) changed also the way send-email options are completed, by asking the git send-email command itself what options it offers. Necessarily, this must fail when built with NO_PERL because send-email itself is a Perl script. Which means that we need the PERL prerequisite for the send-email test case in t9902. Changes since v1: * replaced the commit message by the cover letter, as it was deemed to be more informative. Johannes Schindelin (1): t9902: 'send-email' test case requires PERL t/t9902-completion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7 Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/99 Range-diff vs v1: 1: 32e6bf2dd3 ! 1: 8e3ddff2c7 t9902: 'send-email' test case requires PERL @@ -2,14 +2,14 @@ t9902: 'send-email' test case requires PERL - With NO_PERL, the `git send-email` script errors out with code 128, - mentioning that Git was built without Perl support. + The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin + for format-patch, 2018-11-03) changed also the way send-email options + are completed, by asking the git send-email command itself what options + it offers. - Therefore, when the completion tries to ask for possible completions via - `git send-email --git-completion-helper`, it won't provide what is - necessary for that test case to pass. - - So let's mark it with the PERL prerequisite. + Necessarily, this must fail when built with NO_PERL because send-email + itself is a Perl script. Which means that we need the PERL prerequisite + for the send-email test case in t9902. Signed-off-by: Johannes Schindelin -- gitgitgadget ```