threads / patch / 49377

patchfetch-object.h: add missing declaration (hdr-check)

Subject: [PATCH] fetch-object.h: add missing declaration (hdr-check)

## tl;dr

5 messages between Sep 19, 2018 and Sep 21, 2018. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Ramsay Jones· Sep 19, 2018, 00:18 UTC · lore
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,

This is the patch I needed for the current 'next' branch to get a clean 'hdr-check'

ATB, Ramsay Jones

 fetch-object.h | 2 ++
 1 file changed, 2 insertions(+)
Show changes to fetch-object.h +2 −0
diff --git a/fetch-object.h b/fetch-object.h
index d2f996d4e8..d6444caa5a 100644
--- a/fetch-object.h
+++ b/fetch-object.h
@@ -1,6 +1,8 @@
 #ifndef FETCH_OBJECT_H
 #define FETCH_OBJECT_H
 
+struct object_id;
+
 void fetch_objects(const char *remote_name, const struct object_id *oids,
 		   int oid_nr);
 

-- 
2.19.0
Junio C Hamano· Sep 21, 2018, 16:21 UTC · re: Ramsay Jones · lore

Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
Show 7 quoted lines
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Junio,
>
> This is the patch I needed for the current 'next' branch to get
> a clean 'hdr-check'

Which means that this is a fix on top of jt/lazy-object-fetch-fix topic, I think.

Will apply there.
Thanks.
Ramsay Jones· Sep 21, 2018, 16:47 UTC · re: Junio C Hamano · lore

Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)

On 21/09/18 17:21, Junio C Hamano wrote:
Show 14 quoted lines
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> 
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Junio,
>>
>> This is the patch I needed for the current 'next' branch to get
>> a clean 'hdr-check'
> 
> Which means that this is a fix on top of jt/lazy-object-fetch-fix
> topic, I think.
> 
> Will apply there.

Yes, indeed. Sorry, I should have added that information, rather than forcing you to look it up! (Similar comment on the userdiff.h patch as well) :(

BTW, I notice that patch #9 (commit-reach.h: add missing declarations
 (hdr-check)) didn't make it onto 'pu' - was there something else I
needed to do? (I am still in two minds about sending an RFC patch
on-top of patch #9).
Thanks!

ATB, Ramsay Jones

Junio C Hamano· Sep 21, 2018, 17:05 UTC · re: Ramsay Jones · lore

Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> BTW, I notice that patch #9 (commit-reach.h: add missing declarations
>  (hdr-check)) didn't make it onto 'pu' - was there something else I
> needed to do? (I am still in two minds about sending an RFC patch
> on-top of patch #9).

I refrained from queuing it as I did not sense a clear resolution of the discussion.

I found it a sign that you may want to update the log message to explain "instead of adding a few forward decls, include the whole commit.h because..." that you had to explain why the patch did what it did to Derrick in a follow-up message.

Derrick Stolee· Sep 21, 2018, 17:40 UTC · re: Junio C Hamano · lore

Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)

On 9/21/2018 1:05 PM, Junio C Hamano wrote:
Show 13 quoted lines
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> BTW, I notice that patch #9 (commit-reach.h: add missing declarations
>>   (hdr-check)) didn't make it onto 'pu' - was there something else I
>> needed to do? (I am still in two minds about sending an RFC patch
>> on-top of patch #9).
> I refrained from queuing it as I did not sense a clear resolution of
> the discussion.
>
> I found it a sign that you may want to update the log message to
> explain "instead of adding a few forward decls, include the whole
> commit.h because..." that you had to explain why the patch did what
> it did to Derrick in a follow-up message.

Also my fault for not saying "That's a good reason, thanks for explaining!" (I'll add that to the necessary thread.)

-Stolee

← back to recent threads