# [PATCH] fetch-object.h: add missing declaration (hdr-check) 5 messages from 2018-09-19 to 2018-09-21. Participants: Ramsay Jones, Junio C Hamano, Derrick Stolee. Thread: https://gitlist.dev/t/49377 ## Ramsay Jones, 2018-09-19 00:18 Subject: [PATCH] fetch-object.h: add missing declaration (hdr-check) Message-ID: <12cd9928-d04d-d208-a1b4-ceecbdf79432@ramsayjones.plus.com> URL: https://gitlist.dev/e/12cd9928-d04d-d208-a1b4-ceecbdf79432%40ramsayjones.plus.com ``` Signed-off-by: Ramsay Jones --- Hi Junio, This is the patch I needed for the current 'next' branch to get a clean 'hdr-check' ATB, Ramsay Jones fetch-object.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fetch-object.h b/fetch-object.h index d2f996d4e8..d6444caa5a 100644 --- a/fetch-object.h +++ b/fetch-object.h @@ -1,6 +1,8 @@ #ifndef FETCH_OBJECT_H #define FETCH_OBJECT_H +struct object_id; + void fetch_objects(const char *remote_name, const struct object_id *oids, int oid_nr); -- 2.19.0 ``` ## Junio C Hamano, 2018-09-21 16:21 Subject: Re: [PATCH] fetch-object.h: add missing declaration (hdr-check) Message-ID: URL: https://gitlist.dev/e/xmqq1s9myg67.fsf%40gitster-ct.c.googlers.com In-Reply-To: <12cd9928-d04d-d208-a1b4-ceecbdf79432@ramsayjones.plus.com> ``` Ramsay Jones writes: > Signed-off-by: Ramsay Jones > --- > > Hi Junio, > > This is the patch I needed for the current 'next' branch to get > a clean 'hdr-check' Which means that this is a fix on top of jt/lazy-object-fetch-fix topic, I think. Will apply there. Thanks. ``` ## Ramsay Jones, 2018-09-21 16:47 Subject: Re: [PATCH] fetch-object.h: add missing declaration (hdr-check) Message-ID: URL: https://gitlist.dev/e/f6663e27-cfe6-c927-746c-dfbeed5bb3a2%40ramsayjones.plus.com In-Reply-To: ``` On 21/09/18 17:21, Junio C Hamano wrote: > Ramsay Jones writes: > >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Junio, >> >> This is the patch I needed for the current 'next' branch to get >> a clean 'hdr-check' > > Which means that this is a fix on top of jt/lazy-object-fetch-fix > topic, I think. > > Will apply there. Yes, indeed. Sorry, I should have added that information, rather than forcing you to look it up! (Similar comment on the userdiff.h patch as well) :( BTW, I notice that patch #9 (commit-reach.h: add missing declarations (hdr-check)) didn't make it onto 'pu' - was there something else I needed to do? (I am still in two minds about sending an RFC patch on-top of patch #9). Thanks! ATB, Ramsay Jones ``` ## Junio C Hamano, 2018-09-21 17:05 Subject: Re: [PATCH] fetch-object.h: add missing declaration (hdr-check) Message-ID: URL: https://gitlist.dev/e/xmqq7ejewzl9.fsf%40gitster-ct.c.googlers.com In-Reply-To: ``` Ramsay Jones writes: > BTW, I notice that patch #9 (commit-reach.h: add missing declarations > (hdr-check)) didn't make it onto 'pu' - was there something else I > needed to do? (I am still in two minds about sending an RFC patch > on-top of patch #9). I refrained from queuing it as I did not sense a clear resolution of the discussion. I found it a sign that you may want to update the log message to explain "instead of adding a few forward decls, include the whole commit.h because..." that you had to explain why the patch did what it did to Derrick in a follow-up message. ``` ## Derrick Stolee, 2018-09-21 17:40 Subject: Re: [PATCH] fetch-object.h: add missing declaration (hdr-check) Message-ID: URL: https://gitlist.dev/e/f3fcdef1-e051-0132-5cde-839188374ad7%40gmail.com In-Reply-To: ``` On 9/21/2018 1:05 PM, Junio C Hamano wrote: > Ramsay Jones writes: > >> BTW, I notice that patch #9 (commit-reach.h: add missing declarations >> (hdr-check)) didn't make it onto 'pu' - was there something else I >> needed to do? (I am still in two minds about sending an RFC patch >> on-top of patch #9). > I refrained from queuing it as I did not sense a clear resolution of > the discussion. > > I found it a sign that you may want to update the log message to > explain "instead of adding a few forward decls, include the whole > commit.h because..." that you had to explain why the patch did what > it did to Derrick in a follow-up message. Also my fault for not saying "That's a good reason, thanks for explaining!" (I'll add that to the necessary thread.) -Stolee ```