git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 21, 2018, 17:05 UTC
Message-ID
<xmqq7ejewzl9.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<f6663e27-cfe6-c927-746c-dfbeed5bb3a2@ramsayjones.plus.com>
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> BTW, I notice that patch #9 (commit-reach.h: add missing declarations
>  (hdr-check)) didn't make it onto 'pu' - was there something else I
> needed to do? (I am still in two minds about sending an RFC patch
> on-top of patch #9).

I refrained from queuing it as I did not sense a clear resolution of the discussion.

I found it a sign that you may want to update the log message to explain "instead of adding a few forward decls, include the whole commit.h because..." that you had to explain why the patch did what it did to Derrick in a follow-up message.

Previous: Ramsay JonesNext: Derrick Stolee
Message 4 of 5 in “fetch-object.h: add missing declaration (hdr-check)”
  1. fetch-object.h: add missing declaration (hdr-check)Ramsay Jones, Sep 19, 2018
  2. Junio C HamanoSep 21, 2018
  3. Ramsay JonesSep 21, 2018
  4. Junio C HamanoSep 21, 2018
  5. Derrick StoleeSep 21, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.