Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)

From: Derrick Stolee <stolee@gmail.com>
Date: Sep 21, 2018, 17:40 UTC
Message-ID: <f3fcdef1-e051-0132-5cde-839188374ad7@gmail.com>
In-Reply-To: <xmqq7ejewzl9.fsf@gitster-ct.c.googlers.com>

On 9/21/2018 1:05 PM, Junio C Hamano wrote:

Show 13 quoted lines

> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> BTW, I notice that patch #9 (commit-reach.h: add missing declarations
>>   (hdr-check)) didn't make it onto 'pu' - was there something else I
>> needed to do? (I am still in two minds about sending an RFC patch
>> on-top of patch #9).
> I refrained from queuing it as I did not sense a clear resolution of
> the discussion.
>
> I found it a sign that you may want to update the log message to
> explain "instead of adding a few forward decls, include the whole
> commit.h because..." that you had to explain why the patch did what
> it did to Derrick in a follow-up message.

Also my fault for not saying "That's a good reason, thanks for explaining!" (I'll add that to the necessary thread.)

-Stolee