{"thread":{"id":"49377","subject":"[PATCH] fetch-object.h: add missing declaration (hdr-check)","startedAt":"2018-09-19T00:18:43Z","lastAt":"2018-09-21T17:40:43Z","messageCount":5,"participants":["Ramsay Jones","Junio C Hamano","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"358434","messageId":"12cd9928-d04d-d208-a1b4-ceecbdf79432@ramsayjones.plus.com","threadId":"49377","inReplyTo":null,"subject":"[PATCH] fetch-object.h: add missing declaration (hdr-check)","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-09-19T00:18:39Z","receivedAt":"2018-09-19T00:18:43Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones \n---\n\nHi Junio,\n\nThis is the patch I needed for the current 'next' branch to get\na clean 'hdr-check'\n\nATB,\nRamsay Jones\n\n fetch-object.h | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/fetch-object.h b/fetch-object.h\nindex d2f996d4e8..d6444caa5a 100644\n--- a/fetch-object.h\n+++ b/fetch-object.h\n@@ -1,6 +1,8 @@\n #ifndef FETCH_OBJECT_H\n #define FETCH_OBJECT_H\n \n+struct object_id;\n+\n void fetch_objects(const char *remote_name, const struct object_id *oids,\n \t\t int oid_nr);\n \n-- \n2.19.0\n"},{"id":"358606","messageId":"xmqq1s9myg67.fsf@gitster-ct.c.googlers.com","threadId":"49377","inReplyTo":"12cd9928-d04d-d208-a1b4-ceecbdf79432@ramsayjones.plus.com","subject":"Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-21T16:21:52Z","receivedAt":"2018-09-21T16:21:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones writes:\n\n> Signed-off-by: Ramsay Jones \n> ---\n>\n> Hi Junio,\n>\n> This is the patch I needed for the current 'next' branch to get\n> a clean 'hdr-check'\n\nWhich means that this is a fix on top of jt/lazy-object-fetch-fix\ntopic, I think.\n\nWill apply there.\n\nThanks.\n"},{"id":"358614","messageId":"f6663e27-cfe6-c927-746c-dfbeed5bb3a2@ramsayjones.plus.com","threadId":"49377","inReplyTo":"xmqq1s9myg67.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-09-21T16:47:03Z","receivedAt":"2018-09-21T16:47:06Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 21/09/18 17:21, Junio C Hamano wrote:\n> Ramsay Jones writes:\n> \n>> Signed-off-by: Ramsay Jones \n>> ---\n>>\n>> Hi Junio,\n>>\n>> This is the patch I needed for the current 'next' branch to get\n>> a clean 'hdr-check'\n> \n> Which means that this is a fix on top of jt/lazy-object-fetch-fix\n> topic, I think.\n> \n> Will apply there.\n\nYes, indeed. Sorry, I should have added that information, rather\nthan forcing you to look it up! (Similar comment on the userdiff.h\npatch as well) :(\n\nBTW, I notice that patch #9 (commit-reach.h: add missing declarations\n (hdr-check)) didn't make it onto 'pu' - was there something else I\nneeded to do? (I am still in two minds about sending an RFC patch\non-top of patch #9).\n\nThanks!\n\nATB,\nRamsay Jones\n\n"},{"id":"358617","messageId":"xmqq7ejewzl9.fsf@gitster-ct.c.googlers.com","threadId":"49377","inReplyTo":"f6663e27-cfe6-c927-746c-dfbeed5bb3a2@ramsayjones.plus.com","subject":"Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-21T17:05:22Z","receivedAt":"2018-09-21T17:05:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones writes:\n\n> BTW, I notice that patch #9 (commit-reach.h: add missing declarations\n> (hdr-check)) didn't make it onto 'pu' - was there something else I\n> needed to do? (I am still in two minds about sending an RFC patch\n> on-top of patch #9).\n\nI refrained from queuing it as I did not sense a clear resolution of\nthe discussion.\n\nI found it a sign that you may want to update the log message to\nexplain \"instead of adding a few forward decls, include the whole\ncommit.h because...\" that you had to explain why the patch did what\nit did to Derrick in a follow-up message.\n"},{"id":"358628","messageId":"f3fcdef1-e051-0132-5cde-839188374ad7@gmail.com","threadId":"49377","inReplyTo":"xmqq7ejewzl9.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2018-09-21T17:40:40Z","receivedAt":"2018-09-21T17:40:43Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 9/21/2018 1:05 PM, Junio C Hamano wrote:\n> Ramsay Jones writes:\n>\n>> BTW, I notice that patch #9 (commit-reach.h: add missing declarations\n>> (hdr-check)) didn't make it onto 'pu' - was there something else I\n>> needed to do? (I am still in two minds about sending an RFC patch\n>> on-top of patch #9).\n> I refrained from queuing it as I did not sense a clear resolution of\n> the discussion.\n>\n> I found it a sign that you may want to update the log message to\n> explain \"instead of adding a few forward decls, include the whole\n> commit.h because...\" that you had to explain why the patch did what\n> it did to Derrick in a follow-up message.\n\nAlso my fault for not saying \"That's a good reason, thanks for \nexplaining!\" (I'll add that to the necessary thread.)\n\n-Stolee\n\n"}]}