threads / patch / 46884

patchPR msg: capitalise "Git" to make it a proper noun

Subject: [PATCH] PR msg: capitalise "Git" to make it a proper noun

## tl;dr

5 messages between Oct 2, 2017 and Oct 3, 2017. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Bedhanger· Oct 2, 2017, 22:56 UTC · lore

Of the many ways to spell the three-letter word, the variant "Git" should be used when referring to a repository in a description; or, in general, when it is used as a proper noun.

We thus change the pull-request template message so that it reads
    "...in the Git repository at:"

Besides, this brings us in line with the documentation, see Documentation/howto/using-signed-tag-in-pull-request.txt

Signed-off-by: bedhanger <bedhanger@gmx.de>
---
  git-request-pull.sh     | 2 +-
  t/t5150-request-pull.sh | 4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)
Show changes to 2 files +3 −3

git-request-pull.sh, t/t5150-request-pull.sh

diff --git a/git-request-pull.sh b/git-request-pull.sh
index eebd33276da9..13c172bd94fc 100755
--- a/git-request-pull.sh
+++ b/git-request-pull.sh
@@ -128,7 +128,7 @@ git show -s --format='The following changes since  
commit %H:

    %s (%ci)

-are available in the git repository at:
+are available in the Git repository at:
  ' $merge_base &&
  echo "  $url $pretty_remote" &&
  git show -s --format='
diff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh
index 82c33b88e710..08c210f03586 100755
--- a/t/t5150-request-pull.sh
+++ b/t/t5150-request-pull.sh
@@ -68,7 +68,7 @@ test_expect_success 'setup: two scripts for reading  
pull requests' '
  	cat <<-\EOT >read-request.sed &&
  	#!/bin/sed -nf
  	# Note that a request could ask for "tag $tagname"
-	/ in the git repository at:$/!d
+	/ in the Git repository at:$/!d
  	n
  	/^$/ n
  	s/ tag \([^ ]*\)$/ tag--\1/
@@ -192,7 +192,7 @@ test_expect_success 'pull request format' '

  	  SUBJECT (DATE)

-	are available in the git repository at:
+	are available in the Git repository at:

  	  URL BRANCH

-- 
2.13.6
Jonathan Nieder· Oct 2, 2017, 23:09 UTC · re: Bedhanger · lore

Re: [PATCH] PR msg: capitalise "Git" to make it a proper noun

Hi,
Thanks for working to improve Git!
Bedhanger wrote:
> Subject: [PATCH] PR msg: capitalise "Git" to make it a proper noun

nit: What is a PR msg? Looking with "git log git-request-pull.sh", I see that previous patches called the subsystem request-pull, so this could be

	request-pull: capitalise "Git" to make it a proper noun
Show 12 quoted lines
> Of the many ways to spell the three-letter word, the variant "Git"
> should be used when referring to a repository in a description; or, in
> general, when it is used as a proper noun.
>
> We thus change the pull-request template message so that it reads
>
>    "...in the Git repository at:"
>
> Besides, this brings us in line with the documentation, see
> Documentation/howto/using-signed-tag-in-pull-request.txt
>
> Signed-off-by: bedhanger <bedhanger@gmx.de>

Please use your full name in the Signed-off-by line. See Documentation/SubmittingPatches section "(5) Certify your work" for why we ask for this.

> ---
>  git-request-pull.sh     | 2 +-
>  t/t5150-request-pull.sh | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

The patch itself looks good, and I like the change it makes to the email generated by git request-pull. Looking forward to seeing what other changes you come up with in the future.

Thanks and hope that helps, Jonathan

Ann T Ropea· Oct 3, 2017, 00:08 UTC · re: Jonathan Nieder · lore

Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun

Of the many ways to spell the three-letter word, the variant "Git" should be used when referring to a repository in a description; or, in general, when it is used as a proper noun.

We thus change the pull-request template message so that it reads
    "...in the Git repository at:"

Besides, this brings us in line with the documentation, see Documentation/howto/using-signed-tag-in-pull-request.txt

Signed-off-by: Ann T Ropea <bedhanger@gmx.de>
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
---
v2: rename patch, correct Signed-off-by line, add Acked-by line
  git-request-pull.sh     | 2 +-
  t/t5150-request-pull.sh | 4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)
Show changes to 2 files +3 −3

git-request-pull.sh, t/t5150-request-pull.sh

diff --git a/git-request-pull.sh b/git-request-pull.sh
index eebd33276da9..13c172bd94fc 100755
--- a/git-request-pull.sh
+++ b/git-request-pull.sh
@@ -128,7 +128,7 @@ git show -s --format='The following changes since  
commit %H:

    %s (%ci)

-are available in the git repository at:
+are available in the Git repository at:
  ' $merge_base &&
  echo "  $url $pretty_remote" &&
  git show -s --format='
diff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh
index 82c33b88e710..08c210f03586 100755
--- a/t/t5150-request-pull.sh
+++ b/t/t5150-request-pull.sh
@@ -68,7 +68,7 @@ test_expect_success 'setup: two scripts for reading  
pull requests' '
  	cat <<-\EOT >read-request.sed &&
  	#!/bin/sed -nf
  	# Note that a request could ask for "tag $tagname"
-	/ in the git repository at:$/!d
+	/ in the Git repository at:$/!d
  	n
  	/^$/ n
  	s/ tag \([^ ]*\)$/ tag--\1/
@@ -192,7 +192,7 @@ test_expect_success 'pull request format' '

  	  SUBJECT (DATE)

-	are available in the git repository at:
+	are available in the Git repository at:

  	  URL BRANCH

-- 
2.13.6
Jonathan Nieder· Oct 3, 2017, 00:34 UTC · re: Ann T Ropea · lore

Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun

Ann T Ropea wrote:
Show 18 quoted lines
> Of the many ways to spell the three-letter word, the variant "Git"
> should be used when referring to a repository in a description; or, in
> general, when it is used as a proper noun.
>
> We thus change the pull-request template message so that it reads
>
>    "...in the Git repository at:"
>
> Besides, this brings us in line with the documentation, see
> Documentation/howto/using-signed-tag-in-pull-request.txt
>
> Signed-off-by: Ann T Ropea <bedhanger@gmx.de>
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> v2: rename patch, correct Signed-off-by line, add Acked-by line
>  git-request-pull.sh     | 2 +-
>  t/t5150-request-pull.sh | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks for the quick turnaround.

Sincerely, Jonathan

Junio C Hamano· Oct 3, 2017, 04:12 UTC · re: Jonathan Nieder · lore

Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun

Jonathan Nieder <jrnieder@gmail.com> writes:
Show 24 quoted lines
> Ann T Ropea wrote:
>
>> Of the many ways to spell the three-letter word, the variant "Git"
>> should be used when referring to a repository in a description; or, in
>> general, when it is used as a proper noun.
>>
>> We thus change the pull-request template message so that it reads
>>
>>    "...in the Git repository at:"
>>
>> Besides, this brings us in line with the documentation, see
>> Documentation/howto/using-signed-tag-in-pull-request.txt
>>
>> Signed-off-by: Ann T Ropea <bedhanger@gmx.de>
>> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
>> ---
>> v2: rename patch, correct Signed-off-by line, add Acked-by line
>>  git-request-pull.sh     | 2 +-
>>  t/t5150-request-pull.sh | 4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks for the quick turnaround.

Thanks, but the patch is whitespace damaged and did not apply (what happend to "reviewer's oversight statement" ;-).

As there were only three instances, I just edited the target files and committed, which was far quicker than trying to match whitespaces by editing the patch text.

← back to recent threads