{"thread":{"id":"46884","subject":"[PATCH] PR msg: capitalise \"Git\" to make it a proper noun","startedAt":"2017-10-02T22:56:43Z","lastAt":"2017-10-03T04:12:15Z","messageCount":5,"participants":["Bedhanger","Jonathan Nieder","Ann T Ropea","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"329487","messageId":"20171002225636.Horde.mXj_gBTKz-CxnFKzUqiNDA1@bedhanger.strangled.net","threadId":"46884","inReplyTo":null,"subject":"[PATCH] PR msg: capitalise \"Git\" to make it a proper noun","fromName":"Bedhanger","fromEmail":"bedhanger@gmx.de","sentAt":"2017-10-02T22:56:36Z","receivedAt":"2017-10-02T22:56:43Z","isPatch":true,"sender":{"key":"bedhanger@gmx.de","avatar":"https://avatars.githubusercontent.com/u/21041143?v=4"},"body":"Of the many ways to spell the three-letter word, the variant \"Git\"\nshould be used when referring to a repository in a description; or, in\ngeneral, when it is used as a proper noun.\n\nWe thus change the pull-request template message so that it reads\n\n \"...in the Git repository at:\"\n\nBesides, this brings us in line with the documentation, see\nDocumentation/howto/using-signed-tag-in-pull-request.txt\n\nSigned-off-by: bedhanger \n---\n git-request-pull.sh | 2 +-\n t/t5150-request-pull.sh | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-request-pull.sh b/git-request-pull.sh\nindex eebd33276da9..13c172bd94fc 100755\n--- a/git-request-pull.sh\n+++ b/git-request-pull.sh\n@@ -128,7 +128,7 @@ git show -s --format='The following changes since \ncommit %H:\n\n %s (%ci)\n\n-are available in the git repository at:\n+are available in the Git repository at:\n ' $merge_base &&\n echo \" $url $pretty_remote\" &&\n git show -s --format='\ndiff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh\nindex 82c33b88e710..08c210f03586 100755\n--- a/t/t5150-request-pull.sh\n+++ b/t/t5150-request-pull.sh\n@@ -68,7 +68,7 @@ test_expect_success 'setup: two scripts for reading \npull requests' '\n \tcat <<-\\EOT >read-request.sed &&\n \t#!/bin/sed -nf\n \t# Note that a request could ask for \"tag $tagname\"\n-\t/ in the git repository at:$/!d\n+\t/ in the Git repository at:$/!d\n \tn\n \t/^$/ n\n \ts/ tag \\([^ ]*\\)$/ tag--\\1/\n@@ -192,7 +192,7 @@ test_expect_success 'pull request format' '\n\n \t SUBJECT (DATE)\n\n-\tare available in the git repository at:\n+\tare available in the Git repository at:\n\n \t URL BRANCH\n\n-- \n2.13.6\n\n"},{"id":"329491","messageId":"20171002230959.GU19555@aiede.mtv.corp.google.com","threadId":"46884","inReplyTo":"20171002225636.Horde.mXj_gBTKz-CxnFKzUqiNDA1@bedhanger.strangled.net","subject":"Re: [PATCH] PR msg: capitalise \"Git\" to make it a proper noun","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-10-02T23:09:59Z","receivedAt":"2017-10-02T23:10:06Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nThanks for working to improve Git!\n\nBedhanger wrote:\n\n> Subject: [PATCH] PR msg: capitalise \"Git\" to make it a proper noun\n\nnit: What is a PR msg? Looking with \"git log git-request-pull.sh\",\nI see that previous patches called the subsystem request-pull, so\nthis could be\n\n\trequest-pull: capitalise \"Git\" to make it a proper noun\n\n> Of the many ways to spell the three-letter word, the variant \"Git\"\n> should be used when referring to a repository in a description; or, in\n> general, when it is used as a proper noun.\n>\n> We thus change the pull-request template message so that it reads\n>\n> \"...in the Git repository at:\"\n>\n> Besides, this brings us in line with the documentation, see\n> Documentation/howto/using-signed-tag-in-pull-request.txt\n>\n> Signed-off-by: bedhanger \n\nPlease use your full name in the Signed-off-by line. See\nDocumentation/SubmittingPatches section \"(5) Certify your work\" for\nwhy we ask for this.\n\n> ---\n> git-request-pull.sh | 2 +-\n> t/t5150-request-pull.sh | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n\nThe patch itself looks good, and I like the change it makes to the\nemail generated by git request-pull. Looking forward to seeing what\nother changes you come up with in the future.\n\nThanks and hope that helps,\nJonathan\n"},{"id":"329502","messageId":"20171003000838.Horde.GkejIyyuKI5nlVernhZ1XQ1@bedhanger.strangled.net","threadId":"46884","inReplyTo":"20171002230959.GU19555@aiede.mtv.corp.google.com","subject":"Re: [PATCH v2] request-pull: capitalise \"Git\" to make it a proper noun","fromName":"Ann T Ropea","fromEmail":"bedhanger@gmx.de","sentAt":"2017-10-03T00:08:38Z","receivedAt":"2017-10-03T00:08:46Z","isPatch":true,"sender":{"key":"bedhanger@gmx.de","avatar":"https://avatars.githubusercontent.com/u/21041143?v=4"},"body":"Of the many ways to spell the three-letter word, the variant \"Git\"\nshould be used when referring to a repository in a description; or, in\ngeneral, when it is used as a proper noun.\n\nWe thus change the pull-request template message so that it reads\n\n \"...in the Git repository at:\"\n\nBesides, this brings us in line with the documentation, see\nDocumentation/howto/using-signed-tag-in-pull-request.txt\n\nSigned-off-by: Ann T Ropea \nAcked-by: Jonathan Nieder \n---\nv2: rename patch, correct Signed-off-by line, add Acked-by line\n git-request-pull.sh | 2 +-\n t/t5150-request-pull.sh | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-request-pull.sh b/git-request-pull.sh\nindex eebd33276da9..13c172bd94fc 100755\n--- a/git-request-pull.sh\n+++ b/git-request-pull.sh\n@@ -128,7 +128,7 @@ git show -s --format='The following changes since \ncommit %H:\n\n %s (%ci)\n\n-are available in the git repository at:\n+are available in the Git repository at:\n ' $merge_base &&\n echo \" $url $pretty_remote\" &&\n git show -s --format='\ndiff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh\nindex 82c33b88e710..08c210f03586 100755\n--- a/t/t5150-request-pull.sh\n+++ b/t/t5150-request-pull.sh\n@@ -68,7 +68,7 @@ test_expect_success 'setup: two scripts for reading \npull requests' '\n \tcat <<-\\EOT >read-request.sed &&\n \t#!/bin/sed -nf\n \t# Note that a request could ask for \"tag $tagname\"\n-\t/ in the git repository at:$/!d\n+\t/ in the Git repository at:$/!d\n \tn\n \t/^$/ n\n \ts/ tag \\([^ ]*\\)$/ tag--\\1/\n@@ -192,7 +192,7 @@ test_expect_success 'pull request format' '\n\n \t SUBJECT (DATE)\n\n-\tare available in the git repository at:\n+\tare available in the Git repository at:\n\n \t URL BRANCH\n\n-- \n2.13.6\n\n"},{"id":"329505","messageId":"20171003003407.GW19555@aiede.mtv.corp.google.com","threadId":"46884","inReplyTo":"20171003000838.Horde.GkejIyyuKI5nlVernhZ1XQ1@bedhanger.strangled.net","subject":"Re: [PATCH v2] request-pull: capitalise \"Git\" to make it a proper noun","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-10-03T00:34:07Z","receivedAt":"2017-10-03T00:34:14Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Ann T Ropea wrote:\n\n> Of the many ways to spell the three-letter word, the variant \"Git\"\n> should be used when referring to a repository in a description; or, in\n> general, when it is used as a proper noun.\n>\n> We thus change the pull-request template message so that it reads\n>\n> \"...in the Git repository at:\"\n>\n> Besides, this brings us in line with the documentation, see\n> Documentation/howto/using-signed-tag-in-pull-request.txt\n>\n> Signed-off-by: Ann T Ropea \n> Acked-by: Jonathan Nieder \n> ---\n> v2: rename patch, correct Signed-off-by line, add Acked-by line\n> git-request-pull.sh | 2 +-\n> t/t5150-request-pull.sh | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n\nReviewed-by: Jonathan Nieder \n\nThanks for the quick turnaround.\n\nSincerely,\nJonathan\n"},{"id":"329522","messageId":"xmqq60bwlvjb.fsf@gitster.mtv.corp.google.com","threadId":"46884","inReplyTo":"20171003003407.GW19555@aiede.mtv.corp.google.com","subject":"Re: [PATCH v2] request-pull: capitalise \"Git\" to make it a proper noun","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-10-03T04:12:08Z","receivedAt":"2017-10-03T04:12:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder writes:\n\n> Ann T Ropea wrote:\n>\n>> Of the many ways to spell the three-letter word, the variant \"Git\"\n>> should be used when referring to a repository in a description; or, in\n>> general, when it is used as a proper noun.\n>>\n>> We thus change the pull-request template message so that it reads\n>>\n>> \"...in the Git repository at:\"\n>>\n>> Besides, this brings us in line with the documentation, see\n>> Documentation/howto/using-signed-tag-in-pull-request.txt\n>>\n>> Signed-off-by: Ann T Ropea \n>> Acked-by: Jonathan Nieder \n>> ---\n>> v2: rename patch, correct Signed-off-by line, add Acked-by line\n>> git-request-pull.sh | 2 +-\n>> t/t5150-request-pull.sh | 4 ++--\n>> 2 files changed, 3 insertions(+), 3 deletions(-)\n>\n> Reviewed-by: Jonathan Nieder \n>\n> Thanks for the quick turnaround.\n\nThanks, but the patch is whitespace damaged and did not apply (what\nhappend to \"reviewer's oversight statement\" ;-).\n\nAs there were only three instances, I just edited the target files\nand committed, which was far quicker than trying to match\nwhitespaces by editing the patch text.\n\n"}]}