# [PATCH] PR msg: capitalise "Git" to make it a proper noun 5 messages from 2017-10-02 to 2017-10-03. Participants: Bedhanger, Jonathan Nieder, Ann T Ropea, Junio C Hamano. Thread: https://gitlist.dev/t/46884 ## Bedhanger, 2017-10-02 22:56 Subject: [PATCH] PR msg: capitalise "Git" to make it a proper noun Message-ID: <20171002225636.Horde.mXj_gBTKz-CxnFKzUqiNDA1@bedhanger.strangled.net> URL: https://gitlist.dev/e/20171002225636.Horde.mXj_gBTKz-CxnFKzUqiNDA1%40bedhanger.strangled.net ``` Of the many ways to spell the three-letter word, the variant "Git" should be used when referring to a repository in a description; or, in general, when it is used as a proper noun. We thus change the pull-request template message so that it reads "...in the Git repository at:" Besides, this brings us in line with the documentation, see Documentation/howto/using-signed-tag-in-pull-request.txt Signed-off-by: bedhanger --- git-request-pull.sh | 2 +- t/t5150-request-pull.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/git-request-pull.sh b/git-request-pull.sh index eebd33276da9..13c172bd94fc 100755 --- a/git-request-pull.sh +++ b/git-request-pull.sh @@ -128,7 +128,7 @@ git show -s --format='The following changes since commit %H: %s (%ci) -are available in the git repository at: +are available in the Git repository at: ' $merge_base && echo " $url $pretty_remote" && git show -s --format=' diff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh index 82c33b88e710..08c210f03586 100755 --- a/t/t5150-request-pull.sh +++ b/t/t5150-request-pull.sh @@ -68,7 +68,7 @@ test_expect_success 'setup: two scripts for reading pull requests' ' cat <<-\EOT >read-request.sed && #!/bin/sed -nf # Note that a request could ask for "tag $tagname" - / in the git repository at:$/!d + / in the Git repository at:$/!d n /^$/ n s/ tag \([^ ]*\)$/ tag--\1/ @@ -192,7 +192,7 @@ test_expect_success 'pull request format' ' SUBJECT (DATE) - are available in the git repository at: + are available in the Git repository at: URL BRANCH -- 2.13.6 ``` ## Jonathan Nieder, 2017-10-02 23:09 Subject: Re: [PATCH] PR msg: capitalise "Git" to make it a proper noun Message-ID: <20171002230959.GU19555@aiede.mtv.corp.google.com> URL: https://gitlist.dev/e/20171002230959.GU19555%40aiede.mtv.corp.google.com In-Reply-To: <20171002225636.Horde.mXj_gBTKz-CxnFKzUqiNDA1@bedhanger.strangled.net> ``` Hi, Thanks for working to improve Git! Bedhanger wrote: > Subject: [PATCH] PR msg: capitalise "Git" to make it a proper noun nit: What is a PR msg? Looking with "git log git-request-pull.sh", I see that previous patches called the subsystem request-pull, so this could be request-pull: capitalise "Git" to make it a proper noun > Of the many ways to spell the three-letter word, the variant "Git" > should be used when referring to a repository in a description; or, in > general, when it is used as a proper noun. > > We thus change the pull-request template message so that it reads > > "...in the Git repository at:" > > Besides, this brings us in line with the documentation, see > Documentation/howto/using-signed-tag-in-pull-request.txt > > Signed-off-by: bedhanger Please use your full name in the Signed-off-by line. See Documentation/SubmittingPatches section "(5) Certify your work" for why we ask for this. > --- > git-request-pull.sh | 2 +- > t/t5150-request-pull.sh | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) The patch itself looks good, and I like the change it makes to the email generated by git request-pull. Looking forward to seeing what other changes you come up with in the future. Thanks and hope that helps, Jonathan ``` ## Ann T Ropea, 2017-10-03 00:08 Subject: Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun Message-ID: <20171003000838.Horde.GkejIyyuKI5nlVernhZ1XQ1@bedhanger.strangled.net> URL: https://gitlist.dev/e/20171003000838.Horde.GkejIyyuKI5nlVernhZ1XQ1%40bedhanger.strangled.net In-Reply-To: <20171002230959.GU19555@aiede.mtv.corp.google.com> ``` Of the many ways to spell the three-letter word, the variant "Git" should be used when referring to a repository in a description; or, in general, when it is used as a proper noun. We thus change the pull-request template message so that it reads "...in the Git repository at:" Besides, this brings us in line with the documentation, see Documentation/howto/using-signed-tag-in-pull-request.txt Signed-off-by: Ann T Ropea Acked-by: Jonathan Nieder --- v2: rename patch, correct Signed-off-by line, add Acked-by line git-request-pull.sh | 2 +- t/t5150-request-pull.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/git-request-pull.sh b/git-request-pull.sh index eebd33276da9..13c172bd94fc 100755 --- a/git-request-pull.sh +++ b/git-request-pull.sh @@ -128,7 +128,7 @@ git show -s --format='The following changes since commit %H: %s (%ci) -are available in the git repository at: +are available in the Git repository at: ' $merge_base && echo " $url $pretty_remote" && git show -s --format=' diff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh index 82c33b88e710..08c210f03586 100755 --- a/t/t5150-request-pull.sh +++ b/t/t5150-request-pull.sh @@ -68,7 +68,7 @@ test_expect_success 'setup: two scripts for reading pull requests' ' cat <<-\EOT >read-request.sed && #!/bin/sed -nf # Note that a request could ask for "tag $tagname" - / in the git repository at:$/!d + / in the Git repository at:$/!d n /^$/ n s/ tag \([^ ]*\)$/ tag--\1/ @@ -192,7 +192,7 @@ test_expect_success 'pull request format' ' SUBJECT (DATE) - are available in the git repository at: + are available in the Git repository at: URL BRANCH -- 2.13.6 ``` ## Jonathan Nieder, 2017-10-03 00:34 Subject: Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun Message-ID: <20171003003407.GW19555@aiede.mtv.corp.google.com> URL: https://gitlist.dev/e/20171003003407.GW19555%40aiede.mtv.corp.google.com In-Reply-To: <20171003000838.Horde.GkejIyyuKI5nlVernhZ1XQ1@bedhanger.strangled.net> ``` Ann T Ropea wrote: > Of the many ways to spell the three-letter word, the variant "Git" > should be used when referring to a repository in a description; or, in > general, when it is used as a proper noun. > > We thus change the pull-request template message so that it reads > > "...in the Git repository at:" > > Besides, this brings us in line with the documentation, see > Documentation/howto/using-signed-tag-in-pull-request.txt > > Signed-off-by: Ann T Ropea > Acked-by: Jonathan Nieder > --- > v2: rename patch, correct Signed-off-by line, add Acked-by line > git-request-pull.sh | 2 +- > t/t5150-request-pull.sh | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Jonathan Nieder Thanks for the quick turnaround. Sincerely, Jonathan ``` ## Junio C Hamano, 2017-10-03 04:12 Subject: Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun Message-ID: URL: https://gitlist.dev/e/xmqq60bwlvjb.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20171003003407.GW19555@aiede.mtv.corp.google.com> ``` Jonathan Nieder writes: > Ann T Ropea wrote: > >> Of the many ways to spell the three-letter word, the variant "Git" >> should be used when referring to a repository in a description; or, in >> general, when it is used as a proper noun. >> >> We thus change the pull-request template message so that it reads >> >> "...in the Git repository at:" >> >> Besides, this brings us in line with the documentation, see >> Documentation/howto/using-signed-tag-in-pull-request.txt >> >> Signed-off-by: Ann T Ropea >> Acked-by: Jonathan Nieder >> --- >> v2: rename patch, correct Signed-off-by line, add Acked-by line >> git-request-pull.sh | 2 +- >> t/t5150-request-pull.sh | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) > > Reviewed-by: Jonathan Nieder > > Thanks for the quick turnaround. Thanks, but the patch is whitespace damaged and did not apply (what happend to "reviewer's oversight statement" ;-). As there were only three instances, I just edited the target files and committed, which was far quicker than trying to match whitespaces by editing the patch text. ```