Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun
- From
Ann T Ropea <bedhanger@gmx.de>
- Date
- Oct 3, 2017, 00:08 UTC
- Message-ID
- <20171003000838.Horde.GkejIyyuKI5nlVernhZ1XQ1@bedhanger.strangled.net>
- In-Reply-To
- <20171002230959.GU19555@aiede.mtv.corp.google.com>
Of the many ways to spell the three-letter word, the variant "Git" should be used when referring to a repository in a description; or, in general, when it is used as a proper noun.
We thus change the pull-request template message so that it reads
"...in the Git repository at:"
Besides, this brings us in line with the documentation, see Documentation/howto/using-signed-tag-in-pull-request.txt
Signed-off-by: Ann T Ropea <bedhanger@gmx.de> Acked-by: Jonathan Nieder <jrnieder@gmail.com> --- v2: rename patch, correct Signed-off-by line, add Acked-by line git-request-pull.sh | 2 +- t/t5150-request-pull.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-request-pull.sh b/git-request-pull.sh index eebd33276da9..13c172bd94fc 100755 --- a/git-request-pull.sh +++ b/git-request-pull.sh @@ -128,7 +128,7 @@ git show -s --format='The following changes since commit %H: %s (%ci) -are available in the git repository at: +are available in the Git repository at: ' $merge_base && echo " $url $pretty_remote" && git show -s --format=' diff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh index 82c33b88e710..08c210f03586 100755 --- a/t/t5150-request-pull.sh +++ b/t/t5150-request-pull.sh @@ -68,7 +68,7 @@ test_expect_success 'setup: two scripts for reading pull requests' ' cat <<-\EOT >read-request.sed && #!/bin/sed -nf # Note that a request could ask for "tag $tagname" - / in the git repository at:$/!d + / in the Git repository at:$/!d n /^$/ n s/ tag \([^ ]*\)$/ tag--\1/ @@ -192,7 +192,7 @@ test_expect_success 'pull request format' ' SUBJECT (DATE) - are available in the git repository at: + are available in the Git repository at: URL BRANCH
-- 2.13.6