Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 3, 2017, 04:12 UTC
Message-ID: <xmqq60bwlvjb.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171003003407.GW19555@aiede.mtv.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 24 quoted lines

> Ann T Ropea wrote:
>
>> Of the many ways to spell the three-letter word, the variant "Git"
>> should be used when referring to a repository in a description; or, in
>> general, when it is used as a proper noun.
>>
>> We thus change the pull-request template message so that it reads
>>
>>    "...in the Git repository at:"
>>
>> Besides, this brings us in line with the documentation, see
>> Documentation/howto/using-signed-tag-in-pull-request.txt
>>
>> Signed-off-by: Ann T Ropea <bedhanger@gmx.de>
>> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
>> ---
>> v2: rename patch, correct Signed-off-by line, add Acked-by line
>>  git-request-pull.sh     | 2 +-
>>  t/t5150-request-pull.sh | 4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks for the quick turnaround.

Thanks, but the patch is whitespace damaged and did not apply (what happend to "reviewer's oversight statement" ;-).

As there were only three instances, I just edited the target files and committed, which was far quicker than trying to match whitespaces by editing the patch text.