patchRe: [PATCH/RFC (take 2)] gitweb: New improved patchset view

> > Wouldn't this be confusing with the other fine lines?
> > I personally don't like this chunk separation.  Chunk separation
> > already exists as is and we view it all the time elsewhere.
> 
> But not always the program displaying diff can display such line
> separating chunks, for example on text terminal it can't.

> --- Jakub Narebski <jnareb@gmail.com> wrote:
>>> Wouldn't this be confusing with the other fine lines?
>>> I personally don't like this chunk separation.  Chunk separation
>>> already exists as is and we view it all the time elsewhere.
>> 
>> But not always the program displaying diff can display such line
>> separating chunks, for example on text terminal it can't.
> 
> What I meant is that since I stare at diffs exactly on text terminals,
> my eyes have found other ways to discern chunk blocks.

>> But if you think that the dotted 1px #ffbbff line is too intrusive,
>> we can remove it (and perhaps increase vertical space a few pixels).
>> I'd like to have more opinions first.
> 
> No, I just think that it should be as close as possible to what
> we see now and what we see on text terminals -- no extra vertical
> space please.  Between the two evils, I'd prefer the thin "dotted" line.

>> BTW. you can easily override it in your CSS file.
> 
> Why should we allow something to go into gitweb and disrupt the current
> default behavior only so that people have to change their own css file
> to keep current default behaviour.  Please don't shove this down our
> throats.  Please?

> Jakub Narebski wrote:
>>
>> I'm just saying that with HTML diffs, presented via gitweb in graphical
>> web browser, you have more possibilities, more formatting to use.
> 
> It would be nice though, when the gitweb output would be readable
> on non css-capable browsers (i.e. w3m) too.  At the moment, gitweb
> is mostly usable - the only problematic case is code and diffs.
> These are presented via div-tags so in a non-css browser, all spaces
> are collapsed thereby removing all indentation.  Couldn't code
> fragments be presented via (styled) pre-tags for backward compatibility?
> Pretty please :)

> Btw, while the css version looks nice, Opera seems to have extreme
> performance problems with gitweb's project page when there are a lot
> of repositories.  I.e. trying to view http://gitweb.freedesktop.org/
> brings my system to its knees.  Turning off style sheets cures it
> but then diffs are unusable ...

>
> Edgar Toernig wrote:
>  
> > Btw, while the css version looks nice, Opera seems to have extreme
> > performance problems with gitweb's project page when there are a lot
> > of repositories.  I.e. trying to view http://gitweb.freedesktop.org/
> > brings my system to its knees.  Turning off style sheets cures it
> > but then diffs are unusable ...
> 
> Strange. It's just a simple table. Could you and would you be able to
> debug it further (e.g. by bisecting CSS)?

> >> BTW. you can easily override it in your CSS file.
> > 
> > Why should we allow something to go into gitweb and disrupt the current
> > default behavior only so that people have to change their own css file
> > to keep current default behaviour.  Please don't shove this down our
> > throats.  Please?
> 
> That was just to note that if you don't agree with default, you can change
> it very easily. It is probably the time where people would disagree (for
> example infamous "redundant links" debate) on the gitweb UI; the possibility
> to tailor it easily to your own UI concepts and ideas is in my opinion
> very important (and very nice).

>> That was just to note that if you don't agree with default, you can change
>> it very easily. It is probably the time where people would disagree (for
>> example infamous "redundant links" debate) on the gitweb UI; the possibility
>> to tailor it easily to your own UI concepts and ideas is in my opinion
>> very important (and very nice).
>
> I would like to keep the visual default as stable as possible.
>
>    Luben