{"thread":{"id":"43128","subject":"Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view","startedAt":"2006-10-30T21:34:36Z","lastAt":"2006-10-31T22:41:01Z","messageCount":7,"participants":["Edgar Toernig","Junio C Hamano","Jakub Narebski","Luben Tuikov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"298322","messageId":"850923.44762.qm@web31812.mail.mud.yahoo.com","threadId":"43128","inReplyTo":"200610300905.04454.jnareb@gmail.com","subject":"Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-10-30T21:34:36Z","receivedAt":"2006-10-30T21:34:36Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Jakub Narebski wrote:\n> > Wouldn't this be confusing with the other fine lines?\n> > I personally don't like this chunk separation. Chunk separation\n> > already exists as is and we view it all the time elsewhere.\n> \n> But not always the program displaying diff can display such line\n> separating chunks, for example on text terminal it can't.\n\nWhat I meant is that since I stare at diffs exactly on text terminals,\nmy eyes have found other ways to discern chunk blocks.\n\n> But if you think that the dotted 1px #ffbbff line is too intrusive,\n> we can remove it (and perhaps increase vertical space a few pixels).\n> I'd like to have more opinions first.\n\nNo, I just think that it should be as close as possible to what\nwe see now and what we see on text terminals -- no extra vertical\nspace please. Between the two evils, I'd prefer the thin \"dotted\" line.\n\n> BTW. you can easily override it in your CSS file.\n\nWhy should we allow something to go into gitweb and disrupt the current\ndefault behavior only so that people have to change their own css file\nto keep current default behaviour. Please don't shove this down our\nthroats. Please?\n\n Luben\n"},{"id":"294353","messageId":"200610302250.06733.jnareb@gmail.com","threadId":"43128","inReplyTo":"850923.44762.qm@web31812.mail.mud.yahoo.com","subject":"Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-30T21:50:06Z","receivedAt":"2006-10-30T21:50:06Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Luben Tuikov wrote:\n> --- Jakub Narebski wrote:\n>>> Wouldn't this be confusing with the other fine lines?\n>>> I personally don't like this chunk separation. Chunk separation\n>>> already exists as is and we view it all the time elsewhere.\n>> \n>> But not always the program displaying diff can display such line\n>> separating chunks, for example on text terminal it can't.\n> \n> What I meant is that since I stare at diffs exactly on text terminals,\n> my eyes have found other ways to discern chunk blocks.\n\nI'm just saying that with HTML diffs, presented via gitweb in graphical\nweb browser, you have more possibilities, more formatting to use.\nWhy not make use of it?\n\n>> But if you think that the dotted 1px #ffbbff line is too intrusive,\n>> we can remove it (and perhaps increase vertical space a few pixels).\n>> I'd like to have more opinions first.\n> \n> No, I just think that it should be as close as possible to what\n> we see now and what we see on text terminals -- no extra vertical\n> space please. Between the two evils, I'd prefer the thin \"dotted\" line.\n\nWell, I'll make it nearly invisible in the \"take 3\". BTW. some people\nliked this line, some were indifferent.\n\n>> BTW. you can easily override it in your CSS file.\n> \n> Why should we allow something to go into gitweb and disrupt the current\n> default behavior only so that people have to change their own css file\n> to keep current default behaviour. Please don't shove this down our\n> throats. Please?\n\nThat was just to note that if you don't agree with default, you can change\nit very easily. It is probably the time where people would disagree (for\nexample infamous \"redundant links\" debate) on the gitweb UI; the possibility\nto tailor it easily to your own UI concepts and ideas is in my opinion\nvery important (and very nice).\n\n-- \nJakub Narebski\n"},{"id":"293886","messageId":"20061030233017.19f25117.froese@gmx.de","threadId":"43128","inReplyTo":"200610302250.06733.jnareb@gmail.com","subject":"Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view","fromName":"Edgar Toernig","fromEmail":"froese@gmx.de","sentAt":"2006-10-30T22:30:17Z","receivedAt":"2006-10-30T22:30:17Z","isPatch":true,"sender":{"key":"froese@gmx.de","avatar":null},"body":"Jakub Narebski wrote:\n>\n> I'm just saying that with HTML diffs, presented via gitweb in graphical\n> web browser, you have more possibilities, more formatting to use.\n\nIt would be nice though, when the gitweb output would be readable\non non css-capable browsers (i.e. w3m) too. At the moment, gitweb\nis mostly usable - the only problematic case is code and diffs.\nThese are presented via div-tags so in a non-css browser, all spaces\nare collapsed thereby removing all indentation. Couldn't code\nfragments be presented via (styled) pre-tags for backward compatibility?\nPretty please :)\n\nBtw, while the css version looks nice, Opera seems to have extreme\nperformance problems with gitweb's project page when there are a lot\nof repositories. I.e. trying to view http://gitweb.freedesktop.org/\nbrings my system to its knees. Turning off style sheets cures it\nbut then diffs are unusable ...\n\n"},{"id":"294695","messageId":"200610302339.55128.jnareb@gmail.com","threadId":"43128","inReplyTo":"20061030233017.19f25117.froese@gmx.de","subject":"Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-30T22:39:54Z","receivedAt":"2006-10-30T22:39:54Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Edgar Toernig wrote:\n> Jakub Narebski wrote:\n>>\n>> I'm just saying that with HTML diffs, presented via gitweb in graphical\n>> web browser, you have more possibilities, more formatting to use.\n> \n> It would be nice though, when the gitweb output would be readable\n> on non css-capable browsers (i.e. w3m) too. At the moment, gitweb\n> is mostly usable - the only problematic case is code and diffs.\n> These are presented via div-tags so in a non-css browser, all spaces\n> are collapsed thereby removing all indentation. Couldn't code\n> fragments be presented via (styled) pre-tags for backward compatibility?\n> Pretty please :)\n\nWell, we replaced using s/ / /g with .pre class woth white-space: pre.\nPerhaps we can go halfway, and add 
...
wrapping line.\n \n> Btw, while the css version looks nice, Opera seems to have extreme\n> performance problems with gitweb's project page when there are a lot\n> of repositories. I.e. trying to view http://gitweb.freedesktop.org/\n> brings my system to its knees. Turning off style sheets cures it\n> but then diffs are unusable ...\n\nStrange. It's just a simple table. Could you and would you be able to\ndebug it further (e.g. by bisecting CSS)?\n\n-- \nJakub Narebski\n"},{"id":"297923","messageId":"578323.77588.qm@web31809.mail.mud.yahoo.com","threadId":"43128","inReplyTo":"200610302250.06733.jnareb@gmail.com","subject":"Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-10-30T22:40:28Z","receivedAt":"2006-10-30T22:40:28Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Jakub Narebski wrote:\n> I'm just saying that with HTML diffs, presented via gitweb in graphical\n> web browser, you have more possibilities, more formatting to use.\n> Why not make use of it?\n\nThat sounds fine.\n\nThe question is where one draws the line.\n\n> >> BTW. you can easily override it in your CSS file.\n> > \n> > Why should we allow something to go into gitweb and disrupt the current\n> > default behavior only so that people have to change their own css file\n> > to keep current default behaviour. Please don't shove this down our\n> > throats. Please?\n> \n> That was just to note that if you don't agree with default, you can change\n> it very easily. It is probably the time where people would disagree (for\n> example infamous \"redundant links\" debate) on the gitweb UI; the possibility\n> to tailor it easily to your own UI concepts and ideas is in my opinion\n> very important (and very nice).\n\nI would like to keep the visual default as stable as possible.\n\n Luben\n"},{"id":"294322","messageId":"7v3b95v283.fsf@assigned-by-dhcp.cox.net","threadId":"43128","inReplyTo":"578323.77588.qm@web31809.mail.mud.yahoo.com","subject":"Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-30T23:00:12Z","receivedAt":"2006-10-30T23:00:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov writes:\n\n>> That was just to note that if you don't agree with default, you can change\n>> it very easily. It is probably the time where people would disagree (for\n>> example infamous \"redundant links\" debate) on the gitweb UI; the possibility\n>> to tailor it easily to your own UI concepts and ideas is in my opinion\n>> very important (and very nice).\n>\n> I would like to keep the visual default as stable as possible.\n>\n> Luben\n\nSeconded.\n"},{"id":"295354","messageId":"20061031234101.38e59ac9.froese@gmx.de","threadId":"43128","inReplyTo":"200610302339.55128.jnareb@gmail.com","subject":"Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view","fromName":"Edgar Toernig","fromEmail":"froese@gmx.de","sentAt":"2006-10-31T22:41:01Z","receivedAt":"2006-10-31T22:41:01Z","isPatch":true,"sender":{"key":"froese@gmx.de","avatar":null},"body":"Jakub Narebski wrote:\n>\n> Edgar Toernig wrote:\n> \n> > Btw, while the css version looks nice, Opera seems to have extreme\n> > performance problems with gitweb's project page when there are a lot\n> > of repositories. I.e. trying to view http://gitweb.freedesktop.org/\n> > brings my system to its knees. Turning off style sheets cures it\n> > but then diffs are unusable ...\n> \n> Strange. It's just a simple table. Could you and would you be able to\n> debug it further (e.g. by bisecting CSS)?\n\nIt's the combination of tr.light/dark:hover and background-color.\nChanging the foreground instead of the background color is fast.\nMaybe it recalculates the complete table when the background of\na table cell changes.\n\nI've reported the problem to Opera ...\n\n"}]}