# Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view 7 messages from 2006-10-30 to 2006-10-31. Participants: Edgar Toernig, Junio C Hamano, Jakub Narebski, Luben Tuikov. Thread: https://gitlist.dev/t/43128 ## Luben Tuikov, 2006-10-30 21:34 Subject: Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view Message-ID: <850923.44762.qm@web31812.mail.mud.yahoo.com> URL: https://gitlist.dev/e/850923.44762.qm%40web31812.mail.mud.yahoo.com In-Reply-To: <200610300905.04454.jnareb@gmail.com> ``` --- Jakub Narebski wrote: > > Wouldn't this be confusing with the other fine lines? > > I personally don't like this chunk separation. Chunk separation > > already exists as is and we view it all the time elsewhere. > > But not always the program displaying diff can display such line > separating chunks, for example on text terminal it can't. What I meant is that since I stare at diffs exactly on text terminals, my eyes have found other ways to discern chunk blocks. > But if you think that the dotted 1px #ffbbff line is too intrusive, > we can remove it (and perhaps increase vertical space a few pixels). > I'd like to have more opinions first. No, I just think that it should be as close as possible to what we see now and what we see on text terminals -- no extra vertical space please. Between the two evils, I'd prefer the thin "dotted" line. > BTW. you can easily override it in your CSS file. Why should we allow something to go into gitweb and disrupt the current default behavior only so that people have to change their own css file to keep current default behaviour. Please don't shove this down our throats. Please? Luben ``` ## Jakub Narebski, 2006-10-30 21:50 Subject: Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view Message-ID: <200610302250.06733.jnareb@gmail.com> URL: https://gitlist.dev/e/200610302250.06733.jnareb%40gmail.com In-Reply-To: <850923.44762.qm@web31812.mail.mud.yahoo.com> ``` Luben Tuikov wrote: > --- Jakub Narebski wrote: >>> Wouldn't this be confusing with the other fine lines? >>> I personally don't like this chunk separation. Chunk separation >>> already exists as is and we view it all the time elsewhere. >> >> But not always the program displaying diff can display such line >> separating chunks, for example on text terminal it can't. > > What I meant is that since I stare at diffs exactly on text terminals, > my eyes have found other ways to discern chunk blocks. I'm just saying that with HTML diffs, presented via gitweb in graphical web browser, you have more possibilities, more formatting to use. Why not make use of it? >> But if you think that the dotted 1px #ffbbff line is too intrusive, >> we can remove it (and perhaps increase vertical space a few pixels). >> I'd like to have more opinions first. > > No, I just think that it should be as close as possible to what > we see now and what we see on text terminals -- no extra vertical > space please. Between the two evils, I'd prefer the thin "dotted" line. Well, I'll make it nearly invisible in the "take 3". BTW. some people liked this line, some were indifferent. >> BTW. you can easily override it in your CSS file. > > Why should we allow something to go into gitweb and disrupt the current > default behavior only so that people have to change their own css file > to keep current default behaviour. Please don't shove this down our > throats. Please? That was just to note that if you don't agree with default, you can change it very easily. It is probably the time where people would disagree (for example infamous "redundant links" debate) on the gitweb UI; the possibility to tailor it easily to your own UI concepts and ideas is in my opinion very important (and very nice). -- Jakub Narebski ``` ## Edgar Toernig, 2006-10-30 22:30 Subject: Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view Message-ID: <20061030233017.19f25117.froese@gmx.de> URL: https://gitlist.dev/e/20061030233017.19f25117.froese%40gmx.de In-Reply-To: <200610302250.06733.jnareb@gmail.com> ``` Jakub Narebski wrote: > > I'm just saying that with HTML diffs, presented via gitweb in graphical > web browser, you have more possibilities, more formatting to use. It would be nice though, when the gitweb output would be readable on non css-capable browsers (i.e. w3m) too. At the moment, gitweb is mostly usable - the only problematic case is code and diffs. These are presented via div-tags so in a non-css browser, all spaces are collapsed thereby removing all indentation. Couldn't code fragments be presented via (styled) pre-tags for backward compatibility? Pretty please :) Btw, while the css version looks nice, Opera seems to have extreme performance problems with gitweb's project page when there are a lot of repositories. I.e. trying to view http://gitweb.freedesktop.org/ brings my system to its knees. Turning off style sheets cures it but then diffs are unusable ... ``` ## Jakub Narebski, 2006-10-30 22:39 Subject: Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view Message-ID: <200610302339.55128.jnareb@gmail.com> URL: https://gitlist.dev/e/200610302339.55128.jnareb%40gmail.com In-Reply-To: <20061030233017.19f25117.froese@gmx.de> ``` Edgar Toernig wrote: > Jakub Narebski wrote: >> >> I'm just saying that with HTML diffs, presented via gitweb in graphical >> web browser, you have more possibilities, more formatting to use. > > It would be nice though, when the gitweb output would be readable > on non css-capable browsers (i.e. w3m) too. At the moment, gitweb > is mostly usable - the only problematic case is code and diffs. > These are presented via div-tags so in a non-css browser, all spaces > are collapsed thereby removing all indentation. Couldn't code > fragments be presented via (styled) pre-tags for backward compatibility? > Pretty please :) Well, we replaced using s/ / /g with .pre class woth white-space: pre. Perhaps we can go halfway, and add 
...
wrapping line. > Btw, while the css version looks nice, Opera seems to have extreme > performance problems with gitweb's project page when there are a lot > of repositories. I.e. trying to view http://gitweb.freedesktop.org/ > brings my system to its knees. Turning off style sheets cures it > but then diffs are unusable ... Strange. It's just a simple table. Could you and would you be able to debug it further (e.g. by bisecting CSS)? -- Jakub Narebski ``` ## Luben Tuikov, 2006-10-30 22:40 Subject: Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view Message-ID: <578323.77588.qm@web31809.mail.mud.yahoo.com> URL: https://gitlist.dev/e/578323.77588.qm%40web31809.mail.mud.yahoo.com In-Reply-To: <200610302250.06733.jnareb@gmail.com> ``` --- Jakub Narebski wrote: > I'm just saying that with HTML diffs, presented via gitweb in graphical > web browser, you have more possibilities, more formatting to use. > Why not make use of it? That sounds fine. The question is where one draws the line. > >> BTW. you can easily override it in your CSS file. > > > > Why should we allow something to go into gitweb and disrupt the current > > default behavior only so that people have to change their own css file > > to keep current default behaviour. Please don't shove this down our > > throats. Please? > > That was just to note that if you don't agree with default, you can change > it very easily. It is probably the time where people would disagree (for > example infamous "redundant links" debate) on the gitweb UI; the possibility > to tailor it easily to your own UI concepts and ideas is in my opinion > very important (and very nice). I would like to keep the visual default as stable as possible. Luben ``` ## Junio C Hamano, 2006-10-30 23:00 Subject: Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view Message-ID: <7v3b95v283.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v3b95v283.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <578323.77588.qm@web31809.mail.mud.yahoo.com> ``` Luben Tuikov writes: >> That was just to note that if you don't agree with default, you can change >> it very easily. It is probably the time where people would disagree (for >> example infamous "redundant links" debate) on the gitweb UI; the possibility >> to tailor it easily to your own UI concepts and ideas is in my opinion >> very important (and very nice). > > I would like to keep the visual default as stable as possible. > > Luben Seconded. ``` ## Edgar Toernig, 2006-10-31 22:41 Subject: Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view Message-ID: <20061031234101.38e59ac9.froese@gmx.de> URL: https://gitlist.dev/e/20061031234101.38e59ac9.froese%40gmx.de In-Reply-To: <200610302339.55128.jnareb@gmail.com> ``` Jakub Narebski wrote: > > Edgar Toernig wrote: > > > Btw, while the css version looks nice, Opera seems to have extreme > > performance problems with gitweb's project page when there are a lot > > of repositories. I.e. trying to view http://gitweb.freedesktop.org/ > > brings my system to its knees. Turning off style sheets cures it > > but then diffs are unusable ... > > Strange. It's just a simple table. Could you and would you be able to > debug it further (e.g. by bisecting CSS)? It's the combination of tr.light/dark:hover and background-color. Changing the foreground instead of the background color is fast. Maybe it recalculates the complete table when the background of a table cell changes. I've reported the problem to Opera ... ```