Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 30, 2006, 21:50 UTC
Message-ID: <200610302250.06733.jnareb@gmail.com>
In-Reply-To: <850923.44762.qm@web31812.mail.mud.yahoo.com>

Luben Tuikov wrote:

Show 10 quoted lines

> --- Jakub Narebski <jnareb@gmail.com> wrote:
>>> Wouldn't this be confusing with the other fine lines?
>>> I personally don't like this chunk separation.  Chunk separation
>>> already exists as is and we view it all the time elsewhere.
>> 
>> But not always the program displaying diff can display such line
>> separating chunks, for example on text terminal it can't.
> 
> What I meant is that since I stare at diffs exactly on text terminals,
> my eyes have found other ways to discern chunk blocks.

I'm just saying that with HTML diffs, presented via gitweb in graphical web browser, you have more possibilities, more formatting to use. Why not make use of it?

Show 7 quoted lines

>> But if you think that the dotted 1px #ffbbff line is too intrusive,
>> we can remove it (and perhaps increase vertical space a few pixels).
>> I'd like to have more opinions first.
> 
> No, I just think that it should be as close as possible to what
> we see now and what we see on text terminals -- no extra vertical
> space please.  Between the two evils, I'd prefer the thin "dotted" line.

Well, I'll make it nearly invisible in the "take 3". BTW. some people liked this line, some were indifferent.

Show 6 quoted lines

>> BTW. you can easily override it in your CSS file.
> 
> Why should we allow something to go into gitweb and disrupt the current
> default behavior only so that people have to change their own css file
> to keep current default behaviour.  Please don't shove this down our
> throats.  Please?

That was just to note that if you don't agree with default, you can change it very easily. It is probably the time where people would disagree (for example infamous "redundant links" debate) on the gitweb UI; the possibility to tailor it easily to your own UI concepts and ideas is in my opinion very important (and very nice).

-- 
Jakub Narebski