Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Oct 30, 2006, 21:34 UTC
Message-ID: <850923.44762.qm@web31812.mail.mud.yahoo.com>
In-Reply-To: <200610300905.04454.jnareb@gmail.com>

--- Jakub Narebski <jnareb@gmail.com> wrote:

Show 6 quoted lines

> > Wouldn't this be confusing with the other fine lines?
> > I personally don't like this chunk separation.  Chunk separation
> > already exists as is and we view it all the time elsewhere.
> 
> But not always the program displaying diff can display such line
> separating chunks, for example on text terminal it can't.

What I meant is that since I stare at diffs exactly on text terminals, my eyes have found other ways to discern chunk blocks.

> But if you think that the dotted 1px #ffbbff line is too intrusive,
> we can remove it (and perhaps increase vertical space a few pixels).
> I'd like to have more opinions first.

No, I just think that it should be as close as possible to what we see now and what we see on text terminals -- no extra vertical space please. Between the two evils, I'd prefer the thin "dotted" line.

> BTW. you can easily override it in your CSS file.

Why should we allow something to go into gitweb and disrupt the current default behavior only so that people have to change their own css file to keep current default behaviour. Please don't shove this down our throats. Please?

   Luben