threads / patch / 41465

patchtests: remove unused full-svn-test target

Subject: [PATCH] tests: remove unused full-svn-test target

## tl;dr

4 messages between Feb 22, 2016 and Feb 23, 2016. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Eric Wong· Feb 22, 2016, 03:08 UTC · lore

git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for the "set-tree" sub-command in 9 years since commit 490f49ea5899 ("git-svn: remove optimized commit stuff for set-tree").

So remove this target to avoid confusion.

ref: http://mid.gmane.org/56C9B7B7.7030406@f2.dion.ne.jp

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 t/Makefile | 5 -----
 1 file changed, 5 deletions(-)

Show changes to t/Makefile +0 −5

diff --git a/t/Makefile b/t/Makefile
index 43b15e3..ad97a7e 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -77,11 +77,6 @@ aggregate-results:
 		echo "$$f"; \
 	done | '$(SHELL_PATH_SQ)' ./aggregate-results.sh
 
-# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL
-full-svn-test:
-	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C
-	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8
-
 gitweb-test:
 	$(MAKE) $(TGITWEB)

-- 
EW

Kazutoshi Satoda· Feb 22, 2016, 16:01 UTC · re: Eric Wong · lore

Re: [PATCH] tests: remove unused full-svn-test target

On 2016/02/22 12:08 +0900, Eric Wong wrote:

Show 5 quoted lines

> git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for
> the "set-tree" sub-command in 9 years since commit 490f49ea5899
> ("git-svn: remove optimized commit stuff for set-tree").
> 
> So remove this target to avoid confusion.

> diff --git a/t/Makefile b/t/Makefile
> index 43b15e3..ad97a7e 100644

...

> -# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL
> -full-svn-test:
> -	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C
> -	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8

The variable TSVN becomes unused by this removal. It should be removed together, shouldn't it?

-- 
k_satoda

Eric Wong· Feb 23, 2016, 06:26 UTC · re: Kazutoshi Satoda · lore

[PATCH v2] tests: remove no-op full-svn-test target

git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for the "set-tree" sub-command in 9 years since commit 490f49ea5899 ("git-svn: remove optimized commit stuff for set-tree").

So remove this target and TSVN variable to avoid confusion.

ref: http://mid.gmane.org/56C9B7B7.7030406@f2.dion.ne.jp

Helped-by: Kazutoshi Satoda <k_satoda@f2.dion.ne.jp>
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
  v2: remove TSVN, too.

  Kazutoshi Satoda <k_satoda@f2.dion.ne.jp> wrote:
  > The variable TSVN becomes unused by this removal. It should be removed
  > together, shouldn't it?

  Yes, thanks :)  I also noticed the contrib/subtree/t/Makefile
  has TSVN (and TGITWEB,) too, but I've left it alone for now.

 t/Makefile | 6 ------
 1 file changed, 6 deletions(-)

Show changes to t/Makefile +0 −6

diff --git a/t/Makefile b/t/Makefile
index 43b15e3..18e2b28 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -27,7 +27,6 @@ PERL_PATH_SQ = $(subst ','\'',$(PERL_PATH))
 TEST_RESULTS_DIRECTORY_SQ = $(subst ','\'',$(TEST_RESULTS_DIRECTORY))
 
 T = $(sort $(wildcard t[0-9][0-9][0-9][0-9]-*.sh))
-TSVN = $(sort $(wildcard t91[0-9][0-9]-*.sh))
 TGITWEB = $(sort $(wildcard t95[0-9][0-9]-*.sh))
 THELPERS = $(sort $(filter-out $(T),$(wildcard *.sh)))
 
@@ -77,11 +76,6 @@ aggregate-results:
 		echo "$$f"; \
 	done | '$(SHELL_PATH_SQ)' ./aggregate-results.sh
 
-# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL
-full-svn-test:
-	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C
-	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8
-
 gitweb-test:
 	$(MAKE) $(TGITWEB)

-- 
EW

Junio C Hamano· Feb 23, 2016, 06:31 UTC · re: Eric Wong · lore

Re: [PATCH v2] tests: remove no-op full-svn-test target

Eric Wong <normalperson@yhbt.net> writes:

Show 12 quoted lines

> git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for
> the "set-tree" sub-command in 9 years since commit 490f49ea5899
> ("git-svn: remove optimized commit stuff for set-tree").
>
> So remove this target and TSVN variable to avoid confusion.
>
> ref: http://mid.gmane.org/56C9B7B7.7030406@f2.dion.ne.jp
>
> Helped-by: Kazutoshi Satoda <k_satoda@f2.dion.ne.jp>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
>   v2: remove TSVN, too.

Thanks, both.  Will apply directly on 'master'.