{"thread":{"id":"41465","subject":"[PATCH] tests: remove unused full-svn-test target","startedAt":"2016-02-22T03:08:14Z","lastAt":"2016-02-23T06:31:33Z","messageCount":4,"participants":["Eric Wong","Kazutoshi Satoda","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"278826","messageId":"20160222030814.GA18817@dcvr.yhbt.net","threadId":"41465","inReplyTo":null,"subject":"[PATCH] tests: remove unused full-svn-test target","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2016-02-22T03:08:14Z","receivedAt":"2016-02-22T03:08:14Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for\nthe \"set-tree\" sub-command in 9 years since commit 490f49ea5899\n(\"git-svn: remove optimized commit stuff for set-tree\").\n\nSo remove this target to avoid confusion.\n\nref: http://mid.gmane.org/56C9B7B7.7030406@f2.dion.ne.jp\n\nSigned-off-by: Eric Wong \n---\n t/Makefile | 5 -----\n 1 file changed, 5 deletions(-)\n\ndiff --git a/t/Makefile b/t/Makefile\nindex 43b15e3..ad97a7e 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -77,11 +77,6 @@ aggregate-results:\n \t\techo \"$$f\"; \\\n \tdone | '$(SHELL_PATH_SQ)' ./aggregate-results.sh\n \n-# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL\n-full-svn-test:\n-\t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C\n-\t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8\n-\n gitweb-test:\n \t$(MAKE) $(TGITWEB)\n \n-- \nEW\n"},{"id":"278883","messageId":"56CB30F3.40908@f2.dion.ne.jp","threadId":"41465","inReplyTo":"20160222030814.GA18817@dcvr.yhbt.net","subject":"Re: [PATCH] tests: remove unused full-svn-test target","fromName":"Kazutoshi Satoda","fromEmail":"k_satoda@f2.dion.ne.jp","sentAt":"2016-02-22T16:01:55Z","receivedAt":"2016-02-22T16:01:55Z","isPatch":true,"sender":{"key":"k_satoda@f2.dion.ne.jp","avatar":"https://avatars.githubusercontent.com/u/1337204?v=4"},"body":"On 2016/02/22 12:08 +0900, Eric Wong wrote:\n> git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for\n> the \"set-tree\" sub-command in 9 years since commit 490f49ea5899\n> (\"git-svn: remove optimized commit stuff for set-tree\").\n> \n> So remove this target to avoid confusion.\n\n> diff --git a/t/Makefile b/t/Makefile\n> index 43b15e3..ad97a7e 100644\n...\n> -# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL\n> -full-svn-test:\n> -\t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C\n> -\t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8\n\nThe variable TSVN becomes unused by this removal. It should be removed\ntogether, shouldn't it?\n\n-- \nk_satoda\n"},{"id":"278973","messageId":"20160223062659.GA7630@dcvr.yhbt.net","threadId":"41465","inReplyTo":"56CB30F3.40908@f2.dion.ne.jp","subject":"[PATCH v2] tests: remove no-op full-svn-test target","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2016-02-23T06:26:59Z","receivedAt":"2016-02-23T06:26:59Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for\nthe \"set-tree\" sub-command in 9 years since commit 490f49ea5899\n(\"git-svn: remove optimized commit stuff for set-tree\").\n\nSo remove this target and TSVN variable to avoid confusion.\n\nref: http://mid.gmane.org/56C9B7B7.7030406@f2.dion.ne.jp\n\nHelped-by: Kazutoshi Satoda \nSigned-off-by: Eric Wong \n---\n v2: remove TSVN, too.\n\n Kazutoshi Satoda wrote:\n > The variable TSVN becomes unused by this removal. It should be removed\n > together, shouldn't it?\n\n Yes, thanks :) I also noticed the contrib/subtree/t/Makefile\n has TSVN (and TGITWEB,) too, but I've left it alone for now.\n\n t/Makefile | 6 ------\n 1 file changed, 6 deletions(-)\n\ndiff --git a/t/Makefile b/t/Makefile\nindex 43b15e3..18e2b28 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -27,7 +27,6 @@ PERL_PATH_SQ = $(subst ','\\'',$(PERL_PATH))\n TEST_RESULTS_DIRECTORY_SQ = $(subst ','\\'',$(TEST_RESULTS_DIRECTORY))\n \n T = $(sort $(wildcard t[0-9][0-9][0-9][0-9]-*.sh))\n-TSVN = $(sort $(wildcard t91[0-9][0-9]-*.sh))\n TGITWEB = $(sort $(wildcard t95[0-9][0-9]-*.sh))\n THELPERS = $(sort $(filter-out $(T),$(wildcard *.sh)))\n \n@@ -77,11 +76,6 @@ aggregate-results:\n \t\techo \"$$f\"; \\\n \tdone | '$(SHELL_PATH_SQ)' ./aggregate-results.sh\n \n-# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL\n-full-svn-test:\n-\t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C\n-\t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8\n-\n gitweb-test:\n \t$(MAKE) $(TGITWEB)\n \n-- \nEW\n"},{"id":"278974","messageId":"xmqqvb5g2b0a.fsf@gitster.mtv.corp.google.com","threadId":"41465","inReplyTo":"20160223062659.GA7630@dcvr.yhbt.net","subject":"Re: [PATCH v2] tests: remove no-op full-svn-test target","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-02-23T06:31:33Z","receivedAt":"2016-02-23T06:31:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for\n> the \"set-tree\" sub-command in 9 years since commit 490f49ea5899\n> (\"git-svn: remove optimized commit stuff for set-tree\").\n>\n> So remove this target and TSVN variable to avoid confusion.\n>\n> ref: http://mid.gmane.org/56C9B7B7.7030406@f2.dion.ne.jp\n>\n> Helped-by: Kazutoshi Satoda \n> Signed-off-by: Eric Wong \n> ---\n> v2: remove TSVN, too.\n\nThanks, both. Will apply directly on 'master'.\n"}]}