# [PATCH] tests: remove unused full-svn-test target 4 messages from 2016-02-22 to 2016-02-23. Participants: Eric Wong, Kazutoshi Satoda, Junio C Hamano. Thread: https://gitlist.dev/t/41465 ## Eric Wong, 2016-02-22 03:08 Subject: [PATCH] tests: remove unused full-svn-test target Message-ID: <20160222030814.GA18817@dcvr.yhbt.net> URL: https://gitlist.dev/e/20160222030814.GA18817%40dcvr.yhbt.net ``` git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for the "set-tree" sub-command in 9 years since commit 490f49ea5899 ("git-svn: remove optimized commit stuff for set-tree"). So remove this target to avoid confusion. ref: http://mid.gmane.org/56C9B7B7.7030406@f2.dion.ne.jp Signed-off-by: Eric Wong --- t/Makefile | 5 ----- 1 file changed, 5 deletions(-) diff --git a/t/Makefile b/t/Makefile index 43b15e3..ad97a7e 100644 --- a/t/Makefile +++ b/t/Makefile @@ -77,11 +77,6 @@ aggregate-results: echo "$$f"; \ done | '$(SHELL_PATH_SQ)' ./aggregate-results.sh -# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL -full-svn-test: - $(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C - $(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8 - gitweb-test: $(MAKE) $(TGITWEB) -- EW ``` ## Kazutoshi Satoda, 2016-02-22 16:01 Subject: Re: [PATCH] tests: remove unused full-svn-test target Message-ID: <56CB30F3.40908@f2.dion.ne.jp> URL: https://gitlist.dev/e/56CB30F3.40908%40f2.dion.ne.jp In-Reply-To: <20160222030814.GA18817@dcvr.yhbt.net> ``` On 2016/02/22 12:08 +0900, Eric Wong wrote: > git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for > the "set-tree" sub-command in 9 years since commit 490f49ea5899 > ("git-svn: remove optimized commit stuff for set-tree"). > > So remove this target to avoid confusion. > diff --git a/t/Makefile b/t/Makefile > index 43b15e3..ad97a7e 100644 ... > -# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL > -full-svn-test: > - $(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C > - $(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8 The variable TSVN becomes unused by this removal. It should be removed together, shouldn't it? -- k_satoda ``` ## Eric Wong, 2016-02-23 06:26 Subject: [PATCH v2] tests: remove no-op full-svn-test target Message-ID: <20160223062659.GA7630@dcvr.yhbt.net> URL: https://gitlist.dev/e/20160223062659.GA7630%40dcvr.yhbt.net In-Reply-To: <56CB30F3.40908@f2.dion.ne.jp> ``` git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for the "set-tree" sub-command in 9 years since commit 490f49ea5899 ("git-svn: remove optimized commit stuff for set-tree"). So remove this target and TSVN variable to avoid confusion. ref: http://mid.gmane.org/56C9B7B7.7030406@f2.dion.ne.jp Helped-by: Kazutoshi Satoda Signed-off-by: Eric Wong --- v2: remove TSVN, too. Kazutoshi Satoda wrote: > The variable TSVN becomes unused by this removal. It should be removed > together, shouldn't it? Yes, thanks :) I also noticed the contrib/subtree/t/Makefile has TSVN (and TGITWEB,) too, but I've left it alone for now. t/Makefile | 6 ------ 1 file changed, 6 deletions(-) diff --git a/t/Makefile b/t/Makefile index 43b15e3..18e2b28 100644 --- a/t/Makefile +++ b/t/Makefile @@ -27,7 +27,6 @@ PERL_PATH_SQ = $(subst ','\'',$(PERL_PATH)) TEST_RESULTS_DIRECTORY_SQ = $(subst ','\'',$(TEST_RESULTS_DIRECTORY)) T = $(sort $(wildcard t[0-9][0-9][0-9][0-9]-*.sh)) -TSVN = $(sort $(wildcard t91[0-9][0-9]-*.sh)) TGITWEB = $(sort $(wildcard t95[0-9][0-9]-*.sh)) THELPERS = $(sort $(filter-out $(T),$(wildcard *.sh))) @@ -77,11 +76,6 @@ aggregate-results: echo "$$f"; \ done | '$(SHELL_PATH_SQ)' ./aggregate-results.sh -# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL -full-svn-test: - $(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C - $(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8 - gitweb-test: $(MAKE) $(TGITWEB) -- EW ``` ## Junio C Hamano, 2016-02-23 06:31 Subject: Re: [PATCH v2] tests: remove no-op full-svn-test target Message-ID: URL: https://gitlist.dev/e/xmqqvb5g2b0a.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20160223062659.GA7630@dcvr.yhbt.net> ``` Eric Wong writes: > git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for > the "set-tree" sub-command in 9 years since commit 490f49ea5899 > ("git-svn: remove optimized commit stuff for set-tree"). > > So remove this target and TSVN variable to avoid confusion. > > ref: http://mid.gmane.org/56C9B7B7.7030406@f2.dion.ne.jp > > Helped-by: Kazutoshi Satoda > Signed-off-by: Eric Wong > --- > v2: remove TSVN, too. Thanks, both. Will apply directly on 'master'. ```