git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] tests: remove no-op full-svn-test target

From
EWEric Wong <normalperson@yhbt.net>
Date
Feb 23, 2016, 06:26 UTC
Message-ID
<20160223062659.GA7630@dcvr.yhbt.net>
In-Reply-To
<56CB30F3.40908@f2.dion.ne.jp>

git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for the "set-tree" sub-command in 9 years since commit 490f49ea5899 ("git-svn: remove optimized commit stuff for set-tree").

So remove this target and TSVN variable to avoid confusion.
ref: http://mid.gmane.org/56C9B7B7.7030406@f2.dion.ne.jp
Helped-by: Kazutoshi Satoda <k_satoda@f2.dion.ne.jp>
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
  v2: remove TSVN, too.
  Kazutoshi Satoda <k_satoda@f2.dion.ne.jp> wrote:
  > The variable TSVN becomes unused by this removal. It should be removed
  > together, shouldn't it?
  Yes, thanks :)  I also noticed the contrib/subtree/t/Makefile
  has TSVN (and TGITWEB,) too, but I've left it alone for now.
 t/Makefile | 6 ------
 1 file changed, 6 deletions(-)
diff --git a/t/Makefile b/t/Makefile
index 43b15e3..18e2b28 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -27,7 +27,6 @@ PERL_PATH_SQ = $(subst ','\'',$(PERL_PATH))
 TEST_RESULTS_DIRECTORY_SQ = $(subst ','\'',$(TEST_RESULTS_DIRECTORY))
 
 T = $(sort $(wildcard t[0-9][0-9][0-9][0-9]-*.sh))
-TSVN = $(sort $(wildcard t91[0-9][0-9]-*.sh))
 TGITWEB = $(sort $(wildcard t95[0-9][0-9]-*.sh))
 THELPERS = $(sort $(filter-out $(T),$(wildcard *.sh)))
 
@@ -77,11 +76,6 @@ aggregate-results:
 		echo "$$f"; \
 	done | '$(SHELL_PATH_SQ)' ./aggregate-results.sh
 
-# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL
-full-svn-test:
-	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C
-	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8
-
 gitweb-test:
 	$(MAKE) $(TGITWEB)
 
-- 
EW
Previous: Kazutoshi SatodaNext: Junio C Hamano
Message 3 of 4 in “tests: remove unused full-svn-test target”
  1. tests: remove unused full-svn-test targetEric Wong, Feb 22, 2016
  2. Kazutoshi SatodaFeb 22, 2016
  3. tests: remove no-op full-svn-test targetEric Wong, Feb 23, 2016
  4. Junio C HamanoFeb 23, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.