git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: remove unused full-svn-test target

From
Kazutoshi Satoda <k_satoda@f2.dion.ne.jp>
Date
Feb 22, 2016, 16:01 UTC
Message-ID
<56CB30F3.40908@f2.dion.ne.jp>
In-Reply-To
<20160222030814.GA18817@dcvr.yhbt.net>
On 2016/02/22 12:08 +0900, Eric Wong wrote:
Show 5 quoted lines
> git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for
> the "set-tree" sub-command in 9 years since commit 490f49ea5899
> ("git-svn: remove optimized commit stuff for set-tree").
> 
> So remove this target to avoid confusion.
> diff --git a/t/Makefile b/t/Makefile
> index 43b15e3..ad97a7e 100644
...
> -# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL
> -full-svn-test:
> -	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C
> -	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8

The variable TSVN becomes unused by this removal. It should be removed together, shouldn't it?

-- 
k_satoda
Previous: Eric WongNext: Eric Wong
Message 2 of 4 in “tests: remove unused full-svn-test target”
  1. tests: remove unused full-svn-test targetEric Wong, Feb 22, 2016
  2. Kazutoshi SatodaFeb 22, 2016
  3. tests: remove no-op full-svn-test targetEric Wong, Feb 23, 2016
  4. Junio C HamanoFeb 23, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.