Re: [PATCH] tests: remove unused full-svn-test target
- From
Kazutoshi Satoda <k_satoda@f2.dion.ne.jp>
- Date
- Feb 22, 2016, 16:01 UTC
- Message-ID
- <56CB30F3.40908@f2.dion.ne.jp>
- In-Reply-To
- <20160222030814.GA18817@dcvr.yhbt.net>
On 2016/02/22 12:08 +0900, Eric Wong wrote:
Show 5 quoted lines
> git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for
> the "set-tree" sub-command in 9 years since commit 490f49ea5899
> ("git-svn: remove optimized commit stuff for set-tree").
>
> So remove this target to avoid confusion.> diff --git a/t/Makefile b/t/Makefile > index 43b15e3..ad97a7e 100644
...
> -# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL > -full-svn-test: > - $(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C > - $(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8
The variable TSVN becomes unused by this removal. It should be removed together, shouldn't it?
-- k_satoda