threads / patch / 38719

patchRe: [PATCH][GSoC] revision: forbid --graph and --no-walk usage

Subject: Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage

## tl;dr

3 messages between Mar 6, 2015 and Mar 6, 2015. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Akshay Aurora· Mar 6, 2015, 05:08 UTC · lore

Not sure, why this mail is not showing on Gmane.

I used git to send the email, and tested it by sending the patch to myself before sending it to the list.

On Fri, Mar 6, 2015 at 12:40 AM, Akshay Aurora <akshayaurora@yahoo.com> wrote:

Show 24 quoted lines

> Signed-off-by: Akshay Aurora <akshayaurora@yahoo.com>
> ---
> This is my first patch for a GSoC Microproject, would be great to have your feedback.
>
>  revision.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/revision.c b/revision.c
> index bd027bc..d578652 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
>          */
>         if (revs->reverse && revs->graph)
>                 die("cannot combine --reverse with --graph");
> -
> +       if (revs->no_walk && revs->graph)
> +               die("cannot combine --no-walk with --graph");
>         if (revs->reflog_info && revs->graph)
>                 die("cannot combine --walk-reflogs with --graph");
>         if (!revs->reflog_info && revs->grep_filter.use_reflog_filter)
> --
> 2.3.1
>

-- 
AA

Max Kirillov· Mar 6, 2015, 08:37 UTC · re: Akshay Aurora · lore

On Fri, Mar 6, 2015 at 7:08 AM, Akshay Aurora <akshayaurora@yahoo.com> wrote:

> Not sure, why this mail is not showing on Gmane.
> I used git to send the email, and tested it by sending the patch to
> myself before sending it to the list.

Gmail knows: "Why is this message in Spam? It has a from address in yahoo.com but has failed yahoo.com's required tests for authentication. Learn more" Probably filtering settings are less strict.

I guess you should use authenticated SMTP thought your email hoster, yahoo here in git-send-email (something like --smtp-server and --smtp-user options, it will ask for password interactively) to avoid it.

Akshay Aurora· Mar 6, 2015, 12:11 UTC · re: Max Kirillov · lore

Thanks for replying. I'll try sending the patch directly using gmail smtp servers next time.

Going by the description of the options. I doubt --graph and --no-walk would ever make sense together. So my patch forbids these two options together for all commands calling setup_revisions(). And isn't specific to just `git log`.

Also, seeing other patches to this microproject. I think I should also update Documentation for rev-list-options.

Do you think we need a test for this? Would a test using only `git log` be suffice?

On Fri, Mar 6, 2015 at 2:07 PM, Max Kirillov <max@max630.net> wrote:

Show 14 quoted lines

> On Fri, Mar 6, 2015 at 7:08 AM, Akshay Aurora <akshayaurora@yahoo.com> wrote:
>> Not sure, why this mail is not showing on Gmane.
>> I used git to send the email, and tested it by sending the patch to
>> myself before sending it to the list.
>
> Gmail knows: "Why is this message in Spam? It has a from address in
> yahoo.com but has failed yahoo.com's required tests for
> authentication.  Learn more" Probably filtering settings are less
> strict.
>
> I guess you should use authenticated SMTP thought your email hoster,
> yahoo here in git-send-email (something like --smtp-server and
> --smtp-user options, it will ask for password interactively) to avoid
> it.

-- 
AA