{"thread":{"id":"38719","subject":"Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage","startedAt":"2015-03-06T05:08:56Z","lastAt":"2015-03-06T12:11:20Z","messageCount":3,"participants":["Akshay Aurora","Max Kirillov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"257126","messageId":"CAPGnZZ=WJcd=GWkMqq93RXpJz8jvqnaZctcF2Tni3qkO2vhSOw@mail.gmail.com","threadId":"38719","inReplyTo":"1425582632-28273-1-git-send-email-akshayaurora@yahoo.com","subject":"Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage","fromName":"Akshay Aurora","fromEmail":"akshayaurora@yahoo.com","sentAt":"2015-03-06T05:08:56Z","receivedAt":"2015-03-06T05:08:56Z","isPatch":true,"sender":{"key":"akshayaurora@yahoo.com","avatar":"https://gravatar.com/avatar/07e443d5c5589cab6f36170d55ab46619245b0d58bcb3d8e017e3652f614e856?d=mp&s=160"},"body":"Not sure, why this mail is not showing on Gmane.\n\nI used git to send the email, and tested it by sending the patch to\nmyself before sending it to the list.\n\nOn Fri, Mar 6, 2015 at 12:40 AM, Akshay Aurora <akshayaurora@yahoo.com> wrote:\n> Signed-off-by: Akshay Aurora <akshayaurora@yahoo.com>\n> ---\n> This is my first patch for a GSoC Microproject, would be great to have your feedback.\n>\n>  revision.c | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/revision.c b/revision.c\n> index bd027bc..d578652 100644\n> --- a/revision.c\n> +++ b/revision.c\n> @@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s\n>          */\n>         if (revs->reverse && revs->graph)\n>                 die(\"cannot combine --reverse with --graph\");\n> -\n> +       if (revs->no_walk && revs->graph)\n> +               die(\"cannot combine --no-walk with --graph\");\n>         if (revs->reflog_info && revs->graph)\n>                 die(\"cannot combine --walk-reflogs with --graph\");\n>         if (!revs->reflog_info && revs->grep_filter.use_reflog_filter)\n> --\n> 2.3.1\n>\n\n\n\n-- \nAA\n"},{"id":"257134","messageId":"CAF7_NFRKetzHEB5tfENA=A-wwStwJG7yCbUKYLZos+0WSekeig@mail.gmail.com","threadId":"38719","inReplyTo":"CAPGnZZ=WJcd=GWkMqq93RXpJz8jvqnaZctcF2Tni3qkO2vhSOw@mail.gmail.com","subject":"Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage","fromName":"Max Kirillov","fromEmail":"max@max630.net","sentAt":"2015-03-06T08:37:50Z","receivedAt":"2015-03-06T08:37:50Z","isPatch":true,"sender":{"key":"max@max630.net","avatar":"https://avatars.githubusercontent.com/u/381560?v=4"},"body":"On Fri, Mar 6, 2015 at 7:08 AM, Akshay Aurora <akshayaurora@yahoo.com> wrote:\n> Not sure, why this mail is not showing on Gmane.\n> I used git to send the email, and tested it by sending the patch to\n> myself before sending it to the list.\n\nGmail knows: \"Why is this message in Spam? It has a from address in\nyahoo.com but has failed yahoo.com's required tests for\nauthentication.  Learn more\" Probably filtering settings are less\nstrict.\n\nI guess you should use authenticated SMTP thought your email hoster,\nyahoo here in git-send-email (something like --smtp-server and\n--smtp-user options, it will ask for password interactively) to avoid\nit.\n"},{"id":"257156","messageId":"CAPGnZZkxTMDqfJEogxy2hGJv033t_ehU_LucChpVqqKWRLxR=w@mail.gmail.com","threadId":"38719","inReplyTo":"CAF7_NFRKetzHEB5tfENA=A-wwStwJG7yCbUKYLZos+0WSekeig@mail.gmail.com","subject":"Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage","fromName":"Akshay Aurora","fromEmail":"akshayaurora@yahoo.com","sentAt":"2015-03-06T12:11:20Z","receivedAt":"2015-03-06T12:11:20Z","isPatch":true,"sender":{"key":"akshayaurora@yahoo.com","avatar":"https://gravatar.com/avatar/07e443d5c5589cab6f36170d55ab46619245b0d58bcb3d8e017e3652f614e856?d=mp&s=160"},"body":"Thanks for replying. I'll try sending the patch directly using gmail\nsmtp servers next time.\n\nGoing by the description of the options. I doubt --graph and --no-walk\nwould ever make sense together.\nSo my patch forbids these two options together for all commands\ncalling setup_revisions(). And isn't specific to just `git log`.\n\nAlso, seeing other patches to this microproject. I think I should also\nupdate Documentation for rev-list-options.\n\nDo you think we need a test for this? Would a test using only `git\nlog` be suffice?\n\nOn Fri, Mar 6, 2015 at 2:07 PM, Max Kirillov <max@max630.net> wrote:\n> On Fri, Mar 6, 2015 at 7:08 AM, Akshay Aurora <akshayaurora@yahoo.com> wrote:\n>> Not sure, why this mail is not showing on Gmane.\n>> I used git to send the email, and tested it by sending the patch to\n>> myself before sending it to the list.\n>\n> Gmail knows: \"Why is this message in Spam? It has a from address in\n> yahoo.com but has failed yahoo.com's required tests for\n> authentication.  Learn more\" Probably filtering settings are less\n> strict.\n>\n> I guess you should use authenticated SMTP thought your email hoster,\n> yahoo here in git-send-email (something like --smtp-server and\n> --smtp-user options, it will ask for password interactively) to avoid\n> it.\n\n\n\n-- \nAA\n"}]}