Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage

From: Akshay Aurora <akshayaurora@yahoo.com>
Date: Mar 6, 2015, 05:08 UTC
Message-ID: <CAPGnZZ=WJcd=GWkMqq93RXpJz8jvqnaZctcF2Tni3qkO2vhSOw@mail.gmail.com>
In-Reply-To: <1425582632-28273-1-git-send-email-akshayaurora@yahoo.com>

Not sure, why this mail is not showing on Gmane.

I used git to send the email, and tested it by sending the patch to myself before sending it to the list.

On Fri, Mar 6, 2015 at 12:40 AM, Akshay Aurora <akshayaurora@yahoo.com> wrote:

Show 24 quoted lines

> Signed-off-by: Akshay Aurora <akshayaurora@yahoo.com>
> ---
> This is my first patch for a GSoC Microproject, would be great to have your feedback.
>
>  revision.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/revision.c b/revision.c
> index bd027bc..d578652 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
>          */
>         if (revs->reverse && revs->graph)
>                 die("cannot combine --reverse with --graph");
> -
> +       if (revs->no_walk && revs->graph)
> +               die("cannot combine --no-walk with --graph");
>         if (revs->reflog_info && revs->graph)
>                 die("cannot combine --walk-reflogs with --graph");
>         if (!revs->reflog_info && revs->grep_filter.use_reflog_filter)
> --
> 2.3.1
>

-- 
AA